Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pipeline syntax snippet generation (#198) #199

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

strangelookingnerd
Copy link
Contributor

Fixes #198

The deprecated color field was missing its getter and caused the snippet generation to fail.
The getter was restored and maps to the new style field - similar to the setter.

While at it I also moved the deprecated pipeline steps to the "Advanced / Deprecated" section and added a help text to make users aware of the deprecation and replacement steps.

Testing done

Manually checked that all pipeline steps generate as expected.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@strangelookingnerd strangelookingnerd requested a review from a team as a code owner October 6, 2024 12:10
@strangelookingnerd strangelookingnerd added bug Something isn't working documentation Documentation improvements labels Oct 6, 2024
@strangelookingnerd strangelookingnerd force-pushed the fix_pipeline_syntax_generation branch from 2b85708 to b9c31dc Compare October 6, 2024 12:26
@strangelookingnerd strangelookingnerd force-pushed the fix_pipeline_syntax_generation branch from b9c31dc to 2d06b84 Compare October 6, 2024 12:49
Copy link
Contributor

@mPokornyETM mPokornyETM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@strangelookingnerd strangelookingnerd merged commit 99986b7 into master Oct 7, 2024
20 checks passed
@strangelookingnerd
Copy link
Contributor Author

I’ll cut a release later today.

@strangelookingnerd strangelookingnerd deleted the fix_pipeline_syntax_generation branch October 7, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Documentation improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pipeline syntax snippet generator fails with badge 2.1
2 participants