Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow fields to be optional in declarative pipeline #188

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Allow fields to be optional in declarative pipeline #188

merged 1 commit into from
Sep 17, 2024

Conversation

strangelookingnerd
Copy link
Contributor

See #187

Added @DataBoundConstructor and @DataBoundSetter as appropriate to allow fields to be optional.

Testing done

Manually tested with declarative pipeline and also added new tests for it.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@strangelookingnerd strangelookingnerd added the bug Something isn't working label Sep 17, 2024
@strangelookingnerd strangelookingnerd requested a review from a team as a code owner September 17, 2024 09:34
@strangelookingnerd strangelookingnerd self-assigned this Sep 17, 2024
@strangelookingnerd
Copy link
Contributor Author

@MarkEWaite Could you validate your setup with the incremental?

@strangelookingnerd strangelookingnerd linked an issue Sep 17, 2024 that may be closed by this pull request
Parameters are documented as optional but are not optional #187
Closed
mPokornyETM
mPokornyETM approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@mPokornyETM mPokornyETM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@strangelookingnerd strangelookingnerd merged commit d441fee into master Sep 17, 2024
19 checks passed
@strangelookingnerd strangelookingnerd deleted the fix_187 branch September 17, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mPokornyETM mPokornyETM mPokornyETM approved these changes

@jonesbusy jonesbusy jonesbusy approved these changes

@MarkEWaite MarkEWaite Awaiting requested review from MarkEWaite

Assignees

@strangelookingnerd strangelookingnerd

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parameters are documented as optional but are not optional
3 participants
@strangelookingnerd @jonesbusy @mPokornyETM