Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Renovate #163

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Configure Renovate #163

merged 1 commit into from
Jun 17, 2024

Conversation

strangelookingnerd
Copy link
Contributor

Switch to renovate over dependabot to handle dependency updates.
Eventhough @MarkEWaite is lightning fast when is comes to merging these I personally prefer to use the addtional features of renovate.

Testing done

None.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@strangelookingnerd strangelookingnerd requested a review from a team as a code owner June 17, 2024 13:09
@strangelookingnerd strangelookingnerd added the dependencies Pull requests that update a dependency file label Jun 17, 2024
@mPokornyETM
Copy link
Contributor

features of renovate

which features you means? What are the benefits?

@strangelookingnerd
Copy link
Contributor Author

Me personally prefers the hustle-free automerge capabilities as well as the independence from GitHub (not that it matters too much in this case, but still). Additonally I find it way easier to add version updates in supporting files, e.g. https://github.com/jenkinsci/jenkins/blob/master/.github/renovate.json#L22-L60 or https://github.com/jenkinsci/custom-folder-icon-plugin/blob/main/.github/renovate.json#L27-L34

@mPokornyETM
Copy link
Contributor

Me personally prefers the hustle-free automerge capabilities as well as the independence from GitHub (not that it matters too much in this case, but still). Additonally I find it way easier to add version updates in supporting files, e.g. https://github.com/jenkinsci/jenkins/blob/master/.github/renovate.json#L22-L60 or https://github.com/jenkinsci/custom-folder-icon-plugin/blob/main/.github/renovate.json#L27-L34

then let it try and we will see

Copy link
Contributor

@mPokornyETM mPokornyETM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@strangelookingnerd strangelookingnerd merged commit 38cee5b into master Jun 17, 2024
19 checks passed
@strangelookingnerd strangelookingnerd deleted the switch_to_renovate branch June 17, 2024 14:43
@NotMyFault
Copy link
Member

NotMyFault commented Jun 17, 2024

Renovate has been approved :)

"regexManagers": [
{
"fileMatch": [
".mvn/extensions.xml"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fixed on recent renovate version (renovatebot/renovate#28893)

I confirm it works for self hosted but not aure about the GitHub app

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice, did not know that! Will fix it, thanks for letting me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants