Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve global configuration #150

Merged
merged 1 commit into from
May 15, 2024

Conversation

strangelookingnerd
Copy link
Contributor

Improve the global configuration page and corresponsing code.

  • Move to Security tab -> up for discussion, however I think right now it belongs there
  • Clearer description of config options -> I found Disable OWASP Markup Formatter and If checked, HTML content will not be formatted according OWASP in badges and summary not really helpful as the abbreviation OWASP may not be known to everyone
  • Remove dead / outdated / unneeded code in BadgePlugin

Testing done

Verified configuration is still working and visually pleasing:

grafik

Submitter checklist

Preview Give feedback

@strangelookingnerd strangelookingnerd requested a review from a team as a code owner May 15, 2024 12:31
@strangelookingnerd strangelookingnerd added the enhancement New feature or request label May 15, 2024
* move to Security tab
* clearer description of config
* remove dead / outdated / unneeded code in BadgePlugin
@strangelookingnerd strangelookingnerd force-pushed the improve_global_configuration branch from 0a83b6c to 549b53b Compare May 15, 2024 12:33
@mPokornyETM mPokornyETM added the documentation Documentation improvements label May 15, 2024
Copy link
Contributor

@mPokornyETM mPokornyETM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@strangelookingnerd strangelookingnerd merged commit 73eaed6 into master May 15, 2024
19 checks passed
@strangelookingnerd strangelookingnerd deleted the improve_global_configuration branch May 15, 2024 17:00
@mPokornyETM
Copy link
Contributor

@strangelookingnerd @MarkEWaite pls update the documentation and or release notes, that this is a braking change. We use this option in JCaC and currently after last update will Jenkins no more starts. The solution is to move the config entry like #154
thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation improvements enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants