Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable spotless #142

Merged
merged 2 commits into from
May 11, 2024
Merged

Enable spotless #142

merged 2 commits into from
May 11, 2024

Conversation

strangelookingnerd
Copy link
Contributor

Enables spotless and apply formatting to sources.

Testing done

Ran mvn spotless:apply and verified changes.

Submitter checklist

Preview Give feedback

@strangelookingnerd strangelookingnerd requested a review from a team as a code owner May 11, 2024 12:14
@strangelookingnerd strangelookingnerd added the chore Reduce maintenance label May 11, 2024
@strangelookingnerd strangelookingnerd enabled auto-merge (squash) May 11, 2024 12:14
@strangelookingnerd
Copy link
Contributor Author

@MarkEWaite Any idea why the spotless check runs locally but fails on ci.jenkins.io? Am I missing something?

@MarkEWaite
Copy link
Contributor

@MarkEWaite Any idea why the spotless check runs locally but fails on ci.jenkins.io? Am I missing something?

Just a guess, but maybe your local line termination configuration is different than spotless expects? I ran mvn spotless:apply on my Linux machine and it changed the line termination on several of the files that had been formatted previously. Maybe you're on a platform or have a configuration that needs to be told that Unix line termination is preferred for this repo?

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for using automated formatting! Much easier to read changes in source code when the formatting is consistent.

@MarkEWaite MarkEWaite enabled auto-merge (squash) May 11, 2024 13:17
@MarkEWaite MarkEWaite merged commit 1ce6043 into master May 11, 2024
17 checks passed
@MarkEWaite MarkEWaite deleted the enable_spotless branch May 11, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Reduce maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants