Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling error in README template #138

Merged

Conversation

MarkEWaite
Copy link
Contributor

Fix spelling error in README template

The word 'oj' is now 'ok' to be consistent with other examples.

Testing done

Confirmed that the mvn clean verify only made the common changes to the README, without reverting the earlier spelling fix.

Submitter checklist

Preview Give feedback

@MarkEWaite MarkEWaite requested a review from a team as a code owner May 11, 2024 10:50
@MarkEWaite MarkEWaite added the documentation Documentation improvements label May 11, 2024
Copy link
Contributor

@strangelookingnerd strangelookingnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very tempted to get rid of the entire template / readme generation in favor of a more straight forward solution. To me its over-engineered and error-prone.

@strangelookingnerd strangelookingnerd enabled auto-merge (squash) May 11, 2024 10:58
@strangelookingnerd strangelookingnerd merged commit 0f20746 into jenkinsci:master May 11, 2024
13 of 14 checks passed
@MarkEWaite MarkEWaite deleted the fix-README-spelling-error branch May 11, 2024 11:11
@MarkEWaite
Copy link
Contributor Author

I'm very tempted to get rid of the entire template / readme generation in favor of a more straight forward solution. To me its over-engineered and error-prone.

I think that is a good choice. Full support from me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants