Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tests to run with JUnit5 #137

Merged
merged 1 commit into from
May 11, 2024
Merged

Upgrade tests to run with JUnit5 #137

merged 1 commit into from
May 11, 2024

Conversation

strangelookingnerd
Copy link
Contributor

  • removed JUnit4 dependency
  • migrated namespaces

Testing done

mvn clean verify runs without problems.

Submitter checklist

Preview Give feedback

@strangelookingnerd strangelookingnerd requested a review from a team as a code owner May 11, 2024 10:20
@strangelookingnerd strangelookingnerd self-assigned this May 11, 2024
@strangelookingnerd strangelookingnerd removed the request for review from a team May 11, 2024 10:20
@strangelookingnerd strangelookingnerd force-pushed the junit5 branch 2 times, most recently from 4a70784 to ce29518 Compare May 11, 2024 10:29
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. I compared the JaCoCo coverage report before and after and the change does not reduce coverage. Thanks!

@MarkEWaite MarkEWaite added the test Improvements to test and test infrastructure label May 11, 2024
@MarkEWaite
Copy link
Contributor

I labeled the issue as a test (test improvement task) so that it would be classified by release drafter under one of the common headings in the changelog. You're welcome to assign it a different label if you prefer something else

@strangelookingnerd strangelookingnerd merged commit 924feaa into master May 11, 2024
13 of 14 checks passed
@strangelookingnerd strangelookingnerd added enhancement New feature or request dependencies Pull requests that update a dependency file labels May 11, 2024
@strangelookingnerd strangelookingnerd deleted the junit5 branch May 11, 2024 11:24
@MarkEWaite MarkEWaite removed enhancement New feature or request dependencies Pull requests that update a dependency file labels May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Improvements to test and test infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants