Add symbol to prevent breaking kubernetes plugin with jcasc #50
Conversation
| @@ -401,6 +402,7 @@ public static String getServiceNameWithoutOrchestra(String serviceName) { | |||
| } | |||
|
|
|||
| @Extension | |||
| @Symbol("azureKubernetes") | |||
There was a problem hiding this comment.
Take care of the name here, there is a related one, Azure Container Service (AKS) Plugin.
There was a problem hiding this comment.
I can’t see a cloud in there, it just seemed to have a step called acsDeploy so should be fine unless I’m missing something
There was a problem hiding this comment.
I do cannot propose a better name which would deconflict plugins. Both focus the same feature, more or less. Suggestion below is a technical one which does not help too much
| @Symbol("azureKubernetes") | |
| @Symbol("azureKubernetesCloud") |
There was a problem hiding this comment.
I would prefer not to include cloud in the same as it's part of the extension point.
i.e. for KubernetesCredentials the symbol would be kubernetes
| @@ -401,6 +402,7 @@ public static String getServiceNameWithoutOrchestra(String serviceName) { | |||
| } | |||
|
|
|||
| @Extension | |||
| @Symbol("azureKubernetes") | |||
| public static class DescriptorImpl extends Descriptor<Cloud> { | |||
| @Override | |||
| public String getDisplayName() { | |||
There was a problem hiding this comment.
Time to remove ACS from docs and UI? Should be a separate PR tho
| @@ -401,6 +402,7 @@ public static String getServiceNameWithoutOrchestra(String serviceName) { | |||
| } | |||
|
|
|||
| @Extension | |||
| @Symbol("azureKubernetes") | |||
There was a problem hiding this comment.
I do cannot propose a better name which would deconflict plugins. Both focus the same feature, more or less. Suggestion below is a technical one which does not help too much
| @Symbol("azureKubernetes") | |
| @Symbol("azureKubernetesCloud") |
|
LGTM |
|
Would you be able to ship a release please @xuzhang3 |
Fixes jenkinsci/configuration-as-code-plugin#1337
cc @xuzhang3