Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-67452] Do not add blank external ids #125

Merged
merged 2 commits into from
Feb 10, 2022

Conversation

jtnord
Copy link
Member

@jtnord jtnord commented Feb 2, 2022

Fixes #116

check the externalId is not blank or empty before adding it.

this covers the existing case where a credential was created before the externalId field was introduced (null) as well as after it was where it would be converted to an empty String (which is not a valid external id)

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@batmat batmat changed the title Do not add bank external ids Do not add blank external ids Feb 9, 2022
@jtnord jtnord changed the title Do not add blank external ids [JENKINS-67452] Do not add blank external ids Feb 9, 2022
@Vlatombe Vlatombe added the bug Something isn't working label Feb 9, 2022
@Vlatombe Vlatombe merged commit 3551d56 into jenkinsci:master Feb 10, 2022
@jtnord jtnord deleted the patch-1 branch February 10, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jenkins is failing due to external Id is required in the latest release for IAM role
2 participants