Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #34

Merged
merged 1 commit into from
Aug 20, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ public String getIconClassName() {
}

/**
* Handles the submisson of the authorization configuration.
* Handles the submission of the authorization configuration.
* @param req the request.
* @return the response.
* @throws IOException when things go wrong.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ public String calcCheckPasswordRequestedUrl() {
*
* @param req the request.
* @param userid the userid.
* @return "true" if password fiels is required. this should be evaluated as JavaScript.
* @return "true" if password field is required. this should be evaluated as JavaScript.
*/
@Restricted(NoExternalUse.class) // used by stapler/jelly
@SuppressWarnings("unused")
Expand Down Expand Up @@ -319,7 +319,7 @@ public FormValidation doCheckUserid(@QueryParameter String userid) {
* @param req the request.
* @param userid the user id.
* @param password the password.
* @return the validationr results,
* @return the validation results
*/
@Restricted(NoExternalUse.class) // used by stapler/jelly
@SuppressWarnings("unused")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ THE SOFTWARE.
<f:block>
<table style="width:100%" class="specific-user-authorization">
<!--
hetero-radio makes entries visiable even they are hidden.
hetero-radio makes entries visible even they are hidden.
So nest it not to handled by hetero-radio.
-->
<f:entry title="${%User ID}" field="userid">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
*/

/**
* Swtich password and ApiToken
* Switch password and ApiToken
*/
Behaviour.specify(".specific-user-authorization", "passwordApiTokenSwitch", 0, function (e) {
var findChild = function(startNode) {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<div>
When enabled, regular users will be able to change the configuration of jobs that use this strategy.
This may open up a security risk as the users could potentially configure the job to run scripts
which would enable an ecalation of privilidges attack.
which would enable an escalation of privileges attack.
<br />
When disabled, only users with the <code>RUN_SCRIPTS</code> permisson will be able to either select
When disabled, only users with the <code>RUN_SCRIPTS</code> permission will be able to either select
this strategy or reconfigure a job that uses this strategy.
<br />
<strong>NOTE:</strong> The RUN_SCRIPTS permission is the highest permission available in Jenkins.
By default, all administator users will have the RUN_SCRIPTS permission.
By default, all administrator users will have the RUN_SCRIPTS permission.
</div>
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ public void testConfigurationWithDescriptorNewInstance() throws Exception {
j.submit(wc.goTo("configureSecurity").getFormByName("config"));

/*
// as SpecificUsersAuthorizationStrategy is not annotated with @DataBoundConstoctor,
// as SpecificUsersAuthorizationStrategy is not annotated with @DataBoundConstructor,
// assertEqualDataBoundBeans is not applicable.
j.assertEqualDataBoundBeans(
auth,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ private void prepareJobBasedSecurity() {

@Test
@LocalData
public void testIsAuthenticateionRequiredAsUser() {
public void testIsAuthenticationRequiredAsUser() {
ACL.impersonate(User.get("test1").impersonate());
assertFalse(Jenkins.getInstance().hasPermission(Jenkins.ADMINISTER));
assertFalse(SpecificUsersAuthorizationStrategy.isAuthenticationRequired("test1"));
Expand All @@ -132,15 +132,15 @@ public void testIsAuthenticateionRequiredAsUser() {

@Test
@LocalData
public void testIsAuthenticateionRequiredAsAdministrator() {
public void testIsAuthenticationRequiredAsAdministrator() {
ACL.impersonate(User.get("admin").impersonate());
assertTrue(Jenkins.getInstance().hasPermission(Jenkins.ADMINISTER));
assertFalse(SpecificUsersAuthorizationStrategy.isAuthenticationRequired("test2"));
}

@Test
@LocalData
public void testIsAuthenticateionRequiredAnonymous() {
public void testIsAuthenticationRequiredAnonymous() {
ACL.impersonate(Jenkins.ANONYMOUS);
assertFalse(Jenkins.getInstance().hasPermission(Jenkins.ADMINISTER));
assertTrue(SpecificUsersAuthorizationStrategy.isAuthenticationRequired("test2"));
Expand Down Expand Up @@ -270,7 +270,7 @@ public void testAuthenticate() throws Exception {
}

@Test
public void testUsernotFoundException() throws Exception {
public void testUserNotFoundException() throws Exception {
j.jenkins.setSecurityRealm(new SecurityRealmWithUserFilter(
j.createDummySecurityRealm(),
Arrays.asList("validuser")
Expand Down Expand Up @@ -329,7 +329,7 @@ public void testLoadOnStart() throws Exception {
}

private String getConfigXml(XmlPage page) throws TransformerException {
// {@link XmlPage#asXml} does unneccessary indentations.
// {@link XmlPage#asXml} does unnecessary indentations.
darxriggs marked this conversation as resolved.
Show resolved Hide resolved
Document doc = page.getXmlDocument();
TransformerFactory tfactory = TransformerFactory.newInstance();
Transformer transformer = tfactory.newTransformer();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ public void testLoadOnStart() throws Exception {
}

private String getConfigXml(XmlPage page) throws TransformerException {
// {@link XmlPage#asXml} does unneccessary indentations.
// {@link XmlPage#asXml} does unnecessary indentations.
Document doc = page.getXmlDocument();
TransformerFactory tfactory = TransformerFactory.newInstance();
Transformer transformer = tfactory.newTransformer();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ public void testAuthenticateDownstream() throws Exception {
}

@Test
public void testUsernotFoundException() throws Exception {
public void testUserNotFoundException() throws Exception {
j.jenkins.setSecurityRealm(new SecurityRealmWithUserFilter(
j.createDummySecurityRealm(),
Arrays.asList("validuser")
Expand Down