Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove divBasedFormLayout conditional from jelly files #137

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

MarkEWaite
Copy link
Contributor

Remove divBasedFormLayout from jelly files

Jenkins minimum version is now 2.375.4, the conditional is always true.

Testing done:

  • Modified the updated jelly files and confirmed that I saw each of the modified pages during my testing (debugging strings added temporarily, removed before final commit)
  • Defined a freestyle job and confirmed it ran as expected without access control enabled
  • Defined a Pipeline job and confirmed it ran as expected without access control enabled
  • Enabled access control for builds and allowed "Run as Specific User", "Run as User who Triggered Build", and "Run as anonymous". Confirmed that the setting was honored in the freestyle job and the Pipeline job

Testing detected a mismatched div tag. That was fixed during testing.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Jenkins minimum version is now 2.375.4, the conditional is always true.

Testing done:

* Modified the updated jelly files and confirmed that I saw each of the
  modified pages during my testing (debugging strings added temporarily)
* Defined a freestyle job and confirmed it ran as expected without
  access control enabled
* Defined a Pipeline job and confirmed it ran as expected without
  access control enabled
* Enabled access control for builds and allowed "Run as Specific User",
  "Run as User who Triggered Build", and "Run as anonymous".  Confirmed that
  the setting was honored in the freestyle job and the Pipeline job

Testing detected a mismatched `div` tag.  That was fixed during testing.
@MarkEWaite MarkEWaite added the chore Reduces maintenance effort by changes not directly visible to users label Apr 10, 2023
@MarkEWaite MarkEWaite enabled auto-merge (squash) April 10, 2023 00:49
@MarkEWaite MarkEWaite disabled auto-merge April 10, 2023 00:49
@MarkEWaite MarkEWaite merged commit e3b8ea2 into jenkinsci:master Apr 10, 2023
@MarkEWaite MarkEWaite deleted the remove-divBasedFormLayout branch April 10, 2023 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Reduces maintenance effort by changes not directly visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant