Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Jenkins 2.375.4 or newer #134

Merged
merged 2 commits into from
Apr 1, 2023

Conversation

shoelzle
Copy link
Contributor

@shoelzle shoelzle commented Mar 27, 2023

update base jenkins version to 2.375.4

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request, but I'm not ready at this time to update the minimum required Jenkins version from 2.361.4 to 2.375.4.

Based on plugin installation statistics, only 36% of installations of the plugin are installed on 2.375.1 or newer.

The update to 2.361.4 and Java 11 was a strong incentive for users to upgrade to at least Jenkins 2.361.4 because that upgrade includes configuration as code. However, it was only released last week. I'd prefer to remain on Jenkins 2.361.4 as the minimum Jenkins version for a few months, at least until 2.361.4 is no longer one of the recommended minimum Jenkins versions.

@MarkEWaite
Copy link
Contributor

@shoelzle was there a particular unexpressed reason that prompted this pull request?

@shoelzle
Copy link
Contributor Author

@MarkEWaite, thanks for taking a look at my pull request.

There was no particular reason for me to create this pull request. I simply watched the "Improve a plugin tutorial" and increasing the Jenkins version was the first thing from the list where work seemed to be necassary.

I guess I didn't understand the implications of increasing the Jenkins version. Thanks for your explanation.

@MarkEWaite MarkEWaite added the chore Reduces maintenance effort by changes not directly visible to users label Apr 1, 2023
@MarkEWaite MarkEWaite changed the title update base jenkins version to 2.375.4 Require Jenkins 2.375.4 or newer Apr 1, 2023
@MarkEWaite
Copy link
Contributor

I've given some further thought to the change and I think it makes sense to update to Jenkins 2.375.4 as the minimum Jenkins version. I expect the installation statistics for the plugin will be significantly different in the April 2023 report. Thanks again for the contribution!

@MarkEWaite MarkEWaite enabled auto-merge (squash) April 1, 2023 13:13
@MarkEWaite MarkEWaite merged commit c6fdf47 into jenkinsci:master Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Reduces maintenance effort by changes not directly visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants