Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Code Improvements #131

Merged
merged 5 commits into from
Mar 26, 2023
Merged

Conversation

darxriggs
Copy link
Contributor

No description provided.

There is no need for it.
Variants with 1 and 2 parameters have been mixed before.

As username and password are indentical in tests,
the 1 parameter variant should be used for clarity.
@MarkEWaite MarkEWaite added the chore Reduces maintenance effort by changes not directly visible to users label Mar 26, 2023
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much!

@MarkEWaite MarkEWaite merged commit 1324c2c into jenkinsci:master Mar 26, 2023
@darxriggs darxriggs deleted the improvements branch March 26, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Reduces maintenance effort by changes not directly visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants