Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-56774] Add JCasC support #129

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

basil
Copy link
Member

@basil basil commented Mar 21, 2023

See JENKINS-56774. Completes the work started in #44:

  • Converts all usages of deprecated functionality in production and test code to use the non-deprecated equivalents being introduced in this PR.
  • Adds a new @LocalData-based test to test the migration of the per-project datastructure from a map to two sets.
  • The new test showed that the original change was incorrectly using short names rather than FQCNs for enabledStrategies and disabledStrategies. Adapted the examples in the test suite accordingly.
  • Generated XML files for the old style configuration in the UI with the old version of the plugin, then applied each of the YAML files from the test suite and verified manually that the resulting XML correct.
  • Configured a bunch of settings in the UI with the old version of this plugin, then did a JCasC export with these changes and verified that the result looked correct.
  • Tested end-to-end with Job DSL Groovy Sandboxing.

@basil basil marked this pull request as ready for review March 21, 2023 03:51
@basil basil force-pushed the configuration-as-code branch from 8efcdc3 to eefd2ae Compare March 21, 2023 03:53
Co-authored-by: René Scheibe <rene.scheibe@gmail.com>
@basil basil force-pushed the configuration-as-code branch from eefd2ae to 642e3d0 Compare March 21, 2023 04:11
@basil
Copy link
Member Author

basil commented Mar 21, 2023

From my perspective, this is ready for merge and release.

@MarkEWaite MarkEWaite added the enhancement Improvement or new feature label Mar 21, 2023
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite MarkEWaite merged commit 44647cd into jenkinsci:master Mar 21, 2023
@basil basil deleted the configuration-as-code branch March 21, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement or new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants