Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-62776] Ensure WEB-INF/lib/guava-20.0.jar is bundled #140

Merged
merged 1 commit into from
Jun 26, 2020
Merged

[JENKINS-62776] Ensure WEB-INF/lib/guava-20.0.jar is bundled #140

merged 1 commit into from
Jun 26, 2020

Conversation

jglick
Copy link
Member

@jglick jglick commented Jun 26, 2020

JENKINS-62776: correcting regression in #122, ultimately from jenkinsci/maven-hpi-plugin#140 or jenkinsci/maven-hpi-plugin#172 I think. Verified via manual sanity check.

@jglick jglick added the bug Something isn't working label Jun 26, 2020
@jglick jglick requested a review from Vlatombe June 26, 2020 14:03
Vlatombe
Vlatombe approved these changes Jun 26, 2020
View reviewed changes
Copy link
Member

@Vlatombe Vlatombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. And indeed, packaging should never pick transitive plugin or jenkins core dependencies, so whatever dependency that needs to be packaged must be explicitly mentioned.

@jglick jglick merged commit c64f2c1 into jenkinsci:master Jun 26, 2020
@jglick jglick deleted the guava-JENKINS-62776 branch June 26, 2020 14:22
@jglick jglick mentioned this pull request Oct 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vlatombe Vlatombe Vlatombe approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jglick @Vlatombe