Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the Applitools Plugin for newer versions of Jenkins #11

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

itaibh
Copy link
Collaborator

@itaibh itaibh commented Feb 27, 2023

Fixed the Applitools Plugin for newer versions of Jenkins, by using other method for REST communication.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@itaibh itaibh merged commit a3f6e68 into master Feb 27, 2023
</dependency>
<dependency>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpclient</artifactId>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to not use the apache-httpcomponents-client-4-api plugin here instead?

@sghill
Copy link

sghill commented Mar 14, 2023

Thanks for making this change @itaibh! I don't see a newer version published to the Jenkins repository, is that on the way?

@itaibh
Copy link
Collaborator Author

itaibh commented Mar 14, 2023

Sure, once we remember how to and find the time for that.

@sghill
Copy link

sghill commented Mar 14, 2023

Cool, let me know if I can help.

Happy to resolve the conflicts in #9, and I've set up a plugin on the new GHActions-based Jenkins CD workflow before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants