Trigger tailed log output colorization also after Jenkins restart #227
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the functionality allowing tailed log output to be colorized is executed at the very end of a build - after the log file has already been closed (
onFinalized
). This permits accurate calculation of the point where tailed output will begin and correctColorizedAction.Command.START
action injection. Upon rendering, the new action gets added to the output but since the log file has already been closed the new content is not persisted. As a result tailed log output looks fine until a Jenkins instance gets rebooted. After the restart it gets shown without any ansi code interpreted (full output is fine before and after reboot).The PR fixes this by moving the execution a bit earlier - to
onCompleted
. This point in the lifecycle of aWorkflowRun
happens before log file has been closed so any log amendments get properly persisted and tailed log output gets correctly rendered before and after Jenkins restart. One drawback is that one final line gets added to the log afteronCompleted
so tailed output begin calculation needs to take that into consideration.This change might also work for #216 but I can't be 100% sure as I haven't been able to reproduce that issue.