Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use @LocalData to set up test job #81

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Use @LocalData to set up test job #81

merged 1 commit into from
Jul 7, 2023

Conversation

basil
Copy link
Member

@basil basil commented Jul 5, 2023

Common convention in Jenkins tests is for XML configuration to be put in place with the @LocalData annotation.

Testing done

Ran the relevant test successfully after these changes.

@basil basil added the test label Jul 5, 2023
@basil basil marked this pull request as ready for review July 5, 2023 20:48
@basil basil requested a review from kinow July 7, 2023 18:36
@kinow kinow merged commit 8e74021 into jenkinsci:master Jul 7, 2023
@kinow
Copy link
Member

kinow commented Jul 7, 2023

Thank you!

@basil basil deleted the test branch July 7, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinow kinow kinow approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@basil @kinow