Forward compatibility for tippy

[NotMyFault]

jenkinsci/jenkins#6408

[NotMyFault]

Could someone take a look who has more experience with the ATH pipeline? I don't really see why it would fail, if I fire it up locally it starts well

[timja]

Started with #760 and running the master branch

[timja]

Started with #760 and running the master branch

Master seems to work, PRs are broken

[timja]

cc @jglick / @Vlatombe ref https://github.com/jenkinsci/parallel-test-executor-plugin/releases/tag/316.v1324c7927cc8

[timja]

It seems to be the estimateTestsFromFiles feature.

This can be trivially reproduced by creating a multibranch pipeline pointing at https://github.com/jenkinsci/acceptance-test-harness/

acceptance-test-harness/Jenkinsfile

Line 22 in 279a458

splits = splitTests estimateTestsFromFiles: true, parallelism: count(10)

[timja]

Reverting jenkinsci/parallel-test-executor-plugin#169 fixes it

[timja]

Could someone take a look who has more experience with the ATH pipeline? I don't really see why it would fail, if I fire it up locally it starts well

will be fixed by jenkinsci/parallel-test-executor-plugin#186

I'll replay your build with a workaround

[timja]

Looks like a legit failure @janfaracik

see SshSlavesPluginTest#newAgent

it's trying to make this xhr request:

Clicking the add button does nothing when creating a credential on the new agent screen for ssh build agents

[janfaracik]

Looks like a legit failure @janfaracik

see SshSlavesPluginTest#newAgent

it's trying to make this xhr request:

Clicking the add button does nothing when creating a credential on the new agent screen for ssh build agents

Hmm not working on master either, investigating now

---

Edit: This button was disabled before https://github.com/jenkinsci/credentials-plugin/pull/296/files#diff-a6d35332a3ba531cc756b08e0da0ff4257999e54efc1288c47ebdcff6033d441L152, not sure if it's actually intended to be enabled and removing the disabled attribute was a mistake.

[timja]

@janfaracik Reverting that change doesn't seem to fix it.

@NotMyFault any ideas?

I'll keep poking at it a bit more but don't have much more time atm

[timja]

Seems this is a core bug introduced in 2.344, 2.343 on latest credentials plugin is fine

[timja]

bisected to jenkinsci/jenkins#6464.

[timja]

Matrix auth plugin seems to be broken with this change, it doesn't add new rows, cc @janfaracik

[timja]

This branch fixes row adding but tooltips don't seem to be working:
https://github.com/jenkinsci/matrix-auth-plugin/compare/master...timja:tippy.js?expand=1

[janfaracik]

This branch fixes row adding but tooltips don't seem to be working:
https://github.com/jenkinsci/matrix-auth-plugin/compare/master...timja:tippy.js?expand=1

Opened a fix for that here - jenkinsci/matrix-auth-plugin#120 - thanks!

[timja]

Doesn't seem to be a way to test here with non released plugins easily 😢

[timja]

plugins.SshSlavesPluginTest needs test changes

Needs review:

• credentialsVisibilityTest – core.CredentialsTest
• login_no_ldap – plugins.LdapPluginTest

[janfaracik]

Opened a fix here #795