Fix a flakiness observed when using master.runScript() #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script console is added by Javascript and not completely ready with the page load. Therefore we need to wait for the parts we want to manipulate to be ready. Fixes a flaky test observed when using master.runStript() with the following failure: ``` org.openqa.selenium.NoSuchElementException: Unable to locate element: //*[@path='/script'] ```
jtnord
changed the title
jtnord
changed the title
jtnord
changed the title
aHenryJard
approved these changes
Nov 5, 2020
|
verified failures are not new :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script console is added by Javascript and not completely ready with
the page load.
Therefore we need to wait for the parts we want to manipulate to be
ready.
Fixes a flaky test observed when using master.runStript() with the following failure: