Skip to content

Commit

Permalink
Remove test that checked script security behaviour which has now changed
Browse files Browse the repository at this point in the history
in
jenkinsci/script-security-plugin@f4c0bb9
the functionality being tested was removed
  • Loading branch information
timja committed May 30, 2022
1 parent c589f83 commit fc5591b
Showing 1 changed file with 0 additions and 39 deletions.
39 changes: 0 additions & 39 deletions src/test/java/plugins/JobDslPluginTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -621,45 +621,6 @@ public void should_use_script_approval() {
seedJob.scheduleBuild().shouldSucceed();
}

/**
* Verifies that if script security for Job DSL scripts is enabled,
* scripts saved by non administrators that not run in a Groovy sandbox
* wont be executed.
* If a administrator saves the seed job, any DSL scripts it contains
* will be automatically approved. Afterwards the script
* can be executed.
*/
@Test @WithPlugins({"matrix-auth@2.3","mock-security-realm"})
public void should_approve_administrator_script_automatically() {
setUpSecurity();

jenkins.login().doLogin(USER);
FreeStyleJob seedJob = createSeedJob();
JobDslBuildStep jobDsl = seedJob.addBuildStep(JobDslBuildStep.class);
jobDsl.setScript("job('New_Job')");
jobDsl.setUseSandbox(false);
seedJob.save();

// Build should fail because script is saved from non administrator an not yet approved
Build build = seedJob.scheduleBuild().shouldFail();
assertThat(build.getConsole(), containsString("script not yet approved for use"));

jenkins.logout();
jenkins.login().doLogin(ADMIN);

// Build should fail because script is saved from non administrator an not yet approved
Build build2 = seedJob.scheduleBuild().shouldFail();
assertThat(build2.getConsole(), containsString("script not yet approved for use"));
seedJob.configure();
seedJob.save();

jenkins.logout();
jenkins.login().doLogin(USER);

// Build should succeed because job was saved from administrator
seedJob.scheduleBuild().shouldSucceed();
}

/**
* Verifies that if script security for Job DSL scripts is enabled,
* scripts saved by non administrators can run in a Groovy sandbox
Expand Down

0 comments on commit fc5591b

Please sign in to comment.