Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Jenkins X repositories to go 1.22 #8670

Open
12 of 29 tasks
msvticket opened this issue May 20, 2024 · 22 comments
Open
12 of 29 tasks

Upgrade Jenkins X repositories to go 1.22 #8670

msvticket opened this issue May 20, 2024 · 22 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed in progress kind/task Activity or chore which needs to be done

Comments

@msvticket
Copy link
Member

msvticket commented May 20, 2024

When we were upgrading the go version to 1.18, we noticed that we are limited by the version of go in the goreleaser image. We are now building a custom image where we can set the version of go and install other packages we need. Once that is done, we can start this update work.

Golang supports only 2 major releases: https://endoflife.date/go
The latest version of golang is 1.22

Follow this guide for information on how to upgrade: https://jenkins-x.io/community/maintainer_guide/go-upgrades/

Before upgrading , we need to upgrade the version of golang in the catalog repository:
example (there are other files as well): https://github.com/jenkins-x/jx3-pipeline-catalog/blob/0f0f956d38ffe383ba38d93c1cfe7160a3bec93a/tasks/go/pullrequest.yaml#L37

This is the tentative list of repositories (list will be updated if we find any missing repositories) that we should upgrade:

In the list, there are some packages which need multiple packages updated before we update them, for example: before upgrading jx-api we should upgrade jx-logging.

NOTE: it's fine if you dont follow the order, the order is only there to limit the number of PRs we open as part of an upgrade effort

We will this issue to keep track of which repositories have been or are in the process of being upgraded.
If you are interested in contributing, please comment

I want to upgrade <repo-name>

When opening a PR in these repos to upgrade the go version, remember to include

related to jenkins-x/jx#8670

Don't use fixes as that will close this issue once your PR is merged.
Once your PR is merged, comment in this issue:

<reponame> has been upgraded to 1.22
@msvticket
Copy link
Member Author

I want to upgrade go-scm

msvticket added a commit to jenkins-x/go-scm that referenced this issue Jun 4, 2024
msvticket added a commit to jenkins-x/go-scm that referenced this issue Jun 4, 2024
msvticket added a commit to jenkins-x/jx3-pipeline-catalog that referenced this issue Jun 4, 2024
msvticket added a commit to jenkins-x/jx3-versions that referenced this issue Jun 4, 2024
msvticket added a commit to jenkins-x/go-scm that referenced this issue Jun 4, 2024
msvticket added a commit to jenkins-x/go-scm that referenced this issue Jun 4, 2024
msvticket added a commit to jenkins-x/go-scm that referenced this issue Jun 4, 2024
msvticket added a commit to jenkins-x/jx-kube-client that referenced this issue Jun 4, 2024
also linting fixes

related to jenkins-x/jx#8670
@msvticket
Copy link
Member Author

I want to upgrade jx-kube-client

msvticket added a commit to jenkins-x/logrus-stackdriver-formatter that referenced this issue Jun 4, 2024
make test failures more readable

partly reverting stackskip_test.go to a state that shouldn't need updating on every go upgrade

related to jenkins-x/jx#8670
@msvticket
Copy link
Member Author

I want to upgrade logrus-stackdriver-formatter

msvticket added a commit to jenkins-x/go-scm that referenced this issue Jun 5, 2024
msvticket added a commit to jenkins-x/logrus-stackdriver-formatter that referenced this issue Jun 5, 2024
@msvticket
Copy link
Member Author

I want to upgrade lighthouse

msvticket added a commit to jenkins-x/lighthouse that referenced this issue Jun 5, 2024
also fixing linting

related to jenkins-x/jx#8670
@msvticket
Copy link
Member Author

go-scm has been upgraded to 1.22.3

msvticket added a commit to jenkins-x/lighthouse that referenced this issue Jun 5, 2024
also fixing linting

related to jenkins-x/jx#8670
msvticket added a commit to jenkins-x/lighthouse that referenced this issue Jun 5, 2024
also fixing linting

related to jenkins-x/jx#8670
@msvticket
Copy link
Member Author

lighthouse has been upgraded to 1.22.3

msvticket added a commit to jenkins-x/jx-kube-client that referenced this issue Jun 5, 2024
also linting fixes

related to jenkins-x/jx#8670
msvticket added a commit to jenkins-x/jx-kube-client that referenced this issue Jun 5, 2024
also linting fixes

related to jenkins-x/jx#8670
@JordanGoasdoue
Copy link

@msvticket i've done this one jenkins-x-plugins/jx-gitops#964 in order to reintroduce the CI as before with versionstream, but even locally I have this error :

go: finding module for package k8s.io/api/flowcontrol/v1alpha1
go: github.com/jenkins-x-plugins/jx-gitops/pkg/cmd/apply imports
        github.com/jenkins-x/jx-helpers/v3/pkg/kube imports
        k8s.io/client-go/kubernetes/fake imports
        k8s.io/api/flowcontrol/v1alpha1: module k8s.io/api@latest found (v0.30.2), but does not contain package k8s.io/api/flowcontrol/v1alpha1

seems like it's stuck from other repos (jx-helpers) that are using kubernetes/fake

msvticket added a commit to jenkins-x-plugins/jx-gitops that referenced this issue Jun 19, 2024
upgrade a number of dependencies as well

related to jenkins-x/jx#8670
msvticket added a commit to jenkins-x-plugins/jx-gitops that referenced this issue Jun 20, 2024
update pipelines

related to jenkins-x/jx#8670
msvticket added a commit to jenkins-x-plugins/jx-gitops that referenced this issue Jun 20, 2024
update pipelines
upgrade a number of dependencies

related to jenkins-x/jx#8670
msvticket added a commit to jenkins-x-plugins/jx-gitops that referenced this issue Jun 20, 2024
update pipelines
upgrade a number of dependencies

related to jenkins-x/jx#8670
msvticket added a commit to jenkins-x-plugins/jx-gitops that referenced this issue Jun 24, 2024
update pipelines
upgrade a number of dependencies

related to jenkins-x/jx#8670
msvticket added a commit to jenkins-x-plugins/jx-gitops that referenced this issue Jun 24, 2024
update pipelines
upgrade a number of dependencies

related to jenkins-x/jx#8670
@msvticket
Copy link
Member Author

@msvticket i've done this one jenkins-x-plugins/jx-gitops#964 in order to reintroduce the CI as before with versionstream, but even locally I have this error :

go: finding module for package k8s.io/api/flowcontrol/v1alpha1
go: github.com/jenkins-x-plugins/jx-gitops/pkg/cmd/apply imports
        github.com/jenkins-x/jx-helpers/v3/pkg/kube imports
        k8s.io/client-go/kubernetes/fake imports
        k8s.io/api/flowcontrol/v1alpha1: module k8s.io/api@latest found (v0.30.2), but does not contain package k8s.io/api/flowcontrol/v1alpha1

seems like it's stuck from other repos (jx-helpers) that are using kubernetes/fake

@JordanGoasdoue I fixed his issue in jenkins-x-plugins/jx-gitops#966. Please review!

@msvticket
Copy link
Member Author

I'll upgrade jx-promote

msvticket added a commit to jenkins-x-plugins/jx-promote that referenced this issue Jun 24, 2024
also upgrade dependencies, fixing lint issues and removing use of deprecated pkg/errors

related to jenkins-x/jx#8670

Signed-off-by: Mårten Svantesson <Marten.Svantesson@ticket.se>
msvticket added a commit to jenkins-x-plugins/jx-promote that referenced this issue Jun 24, 2024
upgrade images

related to jenkins-x/jx#8670

Signed-off-by: Mårten Svantesson <Marten.Svantesson@ticket.se>
msvticket added a commit to jenkins-x-plugins/jx-promote that referenced this issue Jun 24, 2024
upgrade images

related to jenkins-x/jx#8670

Signed-off-by: Mårten Svantesson <Marten.Svantesson@ticket.se>
msvticket added a commit to jenkins-x-plugins/jx-promote that referenced this issue Jun 24, 2024
remove problematic step

related to jenkins-x/jx#8670

Signed-off-by: Mårten Svantesson <Marten.Svantesson@ticket.se>
@msvticket
Copy link
Member Author

jx-promote is upgraded

@msvticket
Copy link
Member Author

I'll upgrade jx-updatebot

@msvticket
Copy link
Member Author

I'll upgrade jx-pipeline

msvticket added a commit to jenkins-x-plugins/jx-pipeline that referenced this issue Jul 3, 2024
fixing issues with upgraded lint
removing use of github.com/pkg/errors

related to jenkins-x/jx#8670
msvticket added a commit to jenkins-x-plugins/jx-pipeline that referenced this issue Jul 3, 2024
fixing issues with upgraded lint
removing use of github.com/pkg/errors

related to jenkins-x/jx#8670
msvticket added a commit to jenkins-x-plugins/jx-pipeline that referenced this issue Jul 3, 2024
fixing issues with upgraded lint
removing use of github.com/pkg/errors

related to jenkins-x/jx#8670
msvticket added a commit to jenkins-x-plugins/jx-updatebot that referenced this issue Jul 4, 2024
upgrading various dependenciens
removing use of pkg/errors
fixing lint warnings

related to jenkins-x/jx#8670
@msvticket
Copy link
Member Author

jx-pipeline and jx-updatebot are updated

odinxux pushed a commit to curvetech/jx3-pipeline-catalog that referenced this issue Jul 14, 2024
odinxux pushed a commit to curvetech/jx3-pipeline-catalog that referenced this issue Jul 14, 2024
odinxux pushed a commit to curvetech/jx3-pipeline-catalog that referenced this issue Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed in progress kind/task Activity or chore which needs to be done
Projects
Status: In progress
Development

No branches or pull requests

3 participants