Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CD for docker-workflow #2707

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Enable CD for docker-workflow #2707

merged 1 commit into from
Aug 8, 2022

Conversation

jglick
Copy link
Contributor

@jglick jglick commented Aug 8, 2022

Description

jenkinsci/docker-workflow-plugin#269 is necessary for PCT runs against newer versions of core (between 2.357 and 2.361), apparently requiring https://github.com/jenkinsci/plugin-pom/releases/tag/plugin-4.38 either for jenkinsci/jenkins-test-harness-htmlunit#51 or jenkinsci/jenkins-test-harness-htmlunit#54. Would like to make it easier to push out releases like this though I have no intention of maintaining the plugin from a feature perspective. @rsandell @dwnusbaum @car-roll

Reviewer checklist (not for requesters!)

  • Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
  • Check that the $pluginId Developers team has Admin permissions while granting the access.
  • In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
  • If security contacts are changed (this includes add/remove), ping the security officer (currently @Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

@jglick jglick requested a review from a team as a code owner August 8, 2022 19:40
@timja timja enabled auto-merge (squash) August 8, 2022 19:45
@timja timja merged commit c25f7c2 into jenkins-infra:master Aug 8, 2022
@jglick jglick deleted the patch-1 branch August 8, 2022 19:52
@jglick
Copy link
Contributor Author

jglick commented Aug 8, 2022

(I lack admin access to the repo so cannot check when this takes effect.)

@timja
Copy link
Member

timja commented Aug 8, 2022

Added permission for you

@jglick
Copy link
Contributor Author

jglick commented Aug 8, 2022

Still no secrets. Is the trusted.ci job broken?

@timja
Copy link
Member

timja commented Aug 8, 2022

Still no secrets. Is the trusted.ci job broken?

I think a transient failure.
https://trusted.ci.jenkins.io:1443/blue/organizations/jenkins/repository-permissions-updater/detail/repository-permissions-updater/31138/pipeline

(FYI @daniel-beck)

[2022-08-08T20:01:01.910Z] 2022-08-08 20:01:01.714+0000 [id=1]	INFO	o.c.g.r.c.PlainObjectMetaMethodSite#doInvoke: GET call to retrieve public key for jenkinsci/cloudbees-folder-plugin
[2022-08-08T20:01:01.910Z] Exception in thread "main" java.io.IOException: Server returned HTTP response code: 500 for URL: https://api.github.com/repos/jenkinsci/cloudbees-folder-plugin/actions/secrets/public-key
[2022-08-08T20:01:01.910Z] 	at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1924)
[2022-08-08T20:01:01.910Z] 	at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1520)
[2022-08-08T20:01:01.910Z] 	at java.base/sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:250)
[2022-08-08T20:01:01.910Z] 	at sun.net.www.protocol.https.HttpsURLConnectionImpl$getInputStream$1.call(Unknown Source)
[2022-08-08T20:01:01.910Z] 	at io.jenkins.infra.repository_permissions_updater.GitHubAPI$GitHubImpl.getRepositoryPublicKey(GitHubAPI.groovy:83)
[2022-08-08T20:01:01.910Z] 	at jdk.internal.reflect.GeneratedMethodAccessor65.invoke(Unknown Source)
[2022-08-08T20:01:01.910Z] 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[2022-08-08T20:01:01.910Z] 	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
[2022-08-08T20:01:01.910Z] 	at org.codehaus.groovy.runtime.callsite.PlainObjectMetaMethodSite.doInvoke(PlainObjectMetaMethodSite.java:43)
[2022-08-08T20:01:01.910Z] 	at org.codehaus.groovy.runtime.callsite.PogoMetaMethodSite$PogoCachedMethodSite.invoke(PogoMetaMethodSite.java:167)
[2022-08-08T20:01:01.910Z] 	at org.codehaus.groovy.runtime.callsite.PogoMetaMethodSite.call(PogoMetaMethodSite.java:70)
[2022-08-08T20:01:01.910Z] 	at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:127)
[2022-08-08T20:01:01.910Z] 	at 

@timja
Copy link
Member

timja commented Aug 8, 2022

Secrets are present now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants