Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable CD for external-monitor-job #2330

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Enable CD for external-monitor-job #2330

merged 1 commit into from
Jan 21, 2022

Conversation

jglick
Copy link
Contributor

@jglick jglick commented Jan 21, 2022

Description

jenkinsci/external-monitor-job-plugin#20 (comment) CC @batmat @rsandell @fcojfernandez et al.

Reviewer checklist (not for requesters!)

  • Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
  • Check that the $pluginId Developers team has Admin permissions while granting the access.
  • In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
  • If security contacts are changed (this includes add/remove), ping the security officer (currently @Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

@jglick jglick requested a review from a team as a code owner January 21, 2022 18:28
@timja timja merged commit 9252430 into jenkins-infra:master Jan 21, 2022
@jglick jglick deleted the patch-2 branch January 21, 2022 19:37
@jglick
Copy link
Contributor Author

jglick commented Jan 21, 2022

Have no admin rights to the plugin repo so cannot tell if this worked.

@timja
Copy link
Member

timja commented Jan 21, 2022

fixed

@jglick
Copy link
Contributor Author

jglick commented Jan 21, 2022

Now I can see https://github.com/jenkinsci/external-monitor-job-plugin/settings/secrets/actions and it is empty. Is the RPU job not running?

@timja
Copy link
Member

timja commented Jan 21, 2022

Builds were failing with no space left on the agent. I've deleted the agents, hopefully that'll fix it

@jglick jglick mentioned this pull request Jan 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jglick @timja