Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update core to 2.263.3, args4j to 2.33 #21

Merged
merged 4 commits into from
Jan 30, 2021

Conversation

zbynek
Copy link
Contributor

@zbynek zbynek commented Jan 26, 2021

... and change update the mock code to avoid some exceptions

@MarkEWaite
Copy link
Contributor

I'm not sure why the PR build on ci.jenkins.io runs out of memory and spends 10 hours running, while the master branch completes in 30 minutes or less. Any insights to offer?

@zbynek
Copy link
Contributor Author

zbynek commented Jan 26, 2021

So the main method checks for Exceptions with a comment that they have to be explicitly caught and program exited, otherwise the job keeps hanging. I guess if it encounters an Error instead (such as out of memory) it's not caught and it keeps hanging (maybe because of the memory monitoring thread that runs in parallel?).

I guess the next step is to try it locally with more plugins than the default ~50 and see if I can reproduce the out of memory.

@zbynek zbynek marked this pull request as draft January 26, 2021 22:46
@zbynek zbynek changed the title Update core to 2.249.3, args4j to 2.33 Update core to 2.263.3, args4j to 2.33 Jan 29, 2021
@zbynek zbynek marked this pull request as ready for review January 29, 2021 21:19
@zbynek
Copy link
Contributor Author

zbynek commented Jan 29, 2021

It turns out that this mock

 when(mockJenkins.getRootDir()).thenReturn(new File(System.getProperty("java.io.tmpdir")));

was the cause of builds running for hours and running out of memory. I originally added it to avoid some warnings in the log, but those are not critical.

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Thanks for making the change!

@MarkEWaite
Copy link
Contributor

Merging since @kwhetstone had approved the changes previously.

@MarkEWaite MarkEWaite merged commit 3fb7be4 into jenkins-infra:master Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants