[WEBSITE-434] Show basic step description when detailed check fails #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbynek
changed the title
kwhetstone
approved these changes
Oct 15, 2019
src/main/java/org/jenkinsci/pipeline_steps_doc_generator/ToAsciiDoc.java
Show resolved
Hide resolved
| @@ -158,8 +158,9 @@ public static void main(String[] args){ | |||
| Class<?> delegateOptionType = delegateOptionSchema.getType(); | |||
| Descriptor<?> delegateDescriptor = Jenkins.getInstance().getDescriptor(delegateOptionType.asSubclass(Describable.class)); | |||
| // TODO for some reason, stepsToPlugin contains entries for descriptors but not their describables: | |||
There was a problem hiding this comment.
Update comment if stripping out stepsToPlugin, and explain what's going on here
There was a problem hiding this comment.
The comment is now removed and there are some comments for the new code.
|
LGTM, thanks for adding the comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://issues.jenkins-ci.org/browse/WEBSITE-434
Make sure step reference creates at least the basic description for the special
parallelstep.