Add CD guide for releasing plugins #4341

timja · 2021-05-09T21:59:41Z

Mostly an import of content from https://github.com/jenkinsci/incrementals-tools

content/doc/developer/plugin-development/incrementals.adoc

daniel-beck

Content-wise looks good; unsure whether we want to recommend this as the default just yet (increases pressure on infra team a lot if adopted).

content/doc/developer/publishing/releasing-cd.adoc

timja · 2021-05-10T08:02:40Z

Content-wise looks good; unsure whether we want to recommend this as the default just yet (increases pressure on infra team a lot if adopted).

Does this make sense to add?
https://github.com/jenkins-infra/jenkins.io/pull/4341/files#r629127465

It means that if RPU updating breaks you have a workaround to release still via github.

and it's already documented how to release if ci.jenkins.io is down in the fallback.

jglick

Thanks for driving this!

content/doc/developer/plugin-development/incrementals.adoc

content/redirect/continuous-delivery-of-plugins.md

content/doc/developer/publishing/releasing-cd.adoc

jglick · 2021-05-10T12:57:40Z

content/doc/developer/publishing/releasing-cd.adoc

+
+=== Further troubleshooting help
+
+If none of the provided solutions help, send an email to the link:/mailing-lists[Jenkins developers mailing list] and explain what you did, and how it failed.


Or better to file an INFRA ticket?

well, it'll get sorted a lot quicker in IRC...

While I agree that it will be faster to ask for help on IRC, creating a ticket will be useful for documentation purposes.

better? assuming you meant the lines above, or was i mis-reading =/

issues with releasing have normally gone to the developer mailing list, (unless it's obviously an infra issue)

content/doc/developer/publishing/releasing.adoc

content/doc/developer/publishing/releasing-cd.adoc

jglick · 2021-05-10T13:02:30Z

content/doc/developer/publishing/releasing-cd.adoc

+
+For a regular component whose version number is not that meaningful:
+
+[source,diff]


Maybe we should create a new goal like incrementalify (or option to that goal) to do this sort of edit. And/or a flag in archetypes?

yes that would be great, I was thinking about this at least in context of the IRC bot, is there any reason not to automatically opt new plugins in to the cd.enabled flag? i.e. don't bother adding a flag to Jira in the hosting issue.

Also do we need a new flag in archetypes or can we assume plugins use the is hosted on jenkinsci flag should use this setup?

is there any reason not to automatically opt new plugins in to the cd.enabled flag?

That would be a question for @daniel-beck probably.

can we assume plugins us[ing] the is hosted on jenkinsci flag should use this setup?

We should probably get some more diverse adoption before making this the default for new plugins.

is there any reason not to automatically opt new plugins in to the cd.enabled flag?

Assuming this is asking "why not set this even if unused":

This effectively changes the permission model; anyone with commit access to the repo can deploy (even if jumping through hoops to get the token). Right now folks can add whoever they want to GH as committers and it doesn't affect the bits we distribute; cd.enabled changes this.

Every repo adds about 1-2 seconds to the execution time of the RPU run.

jglick · 2021-05-10T13:02:55Z

FTR https://docs.google.com/document/d/1AnwVFpxZUsIwD_d_JiB2rhAKpAAmEzQim4X9FYV6iCw

Co-authored-by: Jesse Glick <jglick@cloudbees.com>

content/doc/developer/publishing/releasing-cd.adoc

Co-authored-by: Jesse Glick <jglick@cloudbees.com>

oleg-nenashev

I think we should add the preview state disclaimer before merging. The rest of the comments are non-blocking suggestions

content/doc/developer/publishing/releasing-cd.adoc

oleg-nenashev · 2021-05-10T17:54:27Z

content/doc/developer/publishing/releasing-cd.adoc

+- url: /jep/229
+  title: 'JEP-229: Continuous Delivery of Jenkins Components and Plugins'
+---
+


Suggested change

WARNING: Continuous Delivery of Jenkins Components and Plugin (jep:229[]) is currently in preview.

See the referenced Jenkins enhancement proposal and references in it to see the current state.

Any feedback from early adopters will be appreciated.

where is it marked as preview?

It is not. Should be reworded.

Suggested change

NOTE: Continuous Delivery of Jenkins Components and Plugin (jep:229[]) is relatively new.

Any feedback from early adopters will be appreciated.

Roadmap-wise, an initiative is in preview until the respective JEP is formally accepted

https://github.com/jenkinsci/jep/tree/master/jep/14 does not state that as far as I can tell.

I don't think this discussion is for this pull request.

Nothing I can see anywhere states that this requires a preview disclaimer, I think the current disclaimer is appropriate.

Please take the bits about github actions long term to the mailing list as it doesn't belong in this PR

FTR the public roadmap had a preview disclaimer until formal publishing and JEP acceptance approval by the Jenkins Governance Meeting and then by the BDFL delegate. See #3527 for the pull request which removed the disclaimer

That may be true but does not appear to be required?

oleg-nenashev · 2021-05-10T17:55:14Z

content/doc/developer/publishing/releasing.adoc

+references:
+- url: ../releasing-cd
+  title: Through GitHub
+- url: ../releasing-manually


I would keep manual releases here, but no strong opinion

what do you mean ?

What I mean is keeping the manual release guide content here until JEP-229 is accepted. I am not blocking the PR by this comment

Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>

jglick · 2021-05-11T17:25:29Z

content/doc/developer/publishing/releasing-cd.adoc

+- url: /jep/229
+  title: 'JEP-229: Continuous Delivery of Jenkins Components and Plugins'
+---
+


Suggested change

NOTE: Continuous Delivery of Jenkins Components and Plugin (jep:229[]) is relatively new.

Any feedback from early adopters will be appreciated.

Co-authored-by: Jesse Glick <jglick@cloudbees.com>

content/doc/developer/publishing/releasing-cd.adoc

oleg-nenashev

"is relatively new" IMHO does not explain the current state. IMHO we have not yet reached a consensus whether we want to keep using GitHub actions in longer term

oleg-nenashev · 2021-05-13T21:38:49Z

content/doc/developer/publishing/releasing-cd.adoc

+- url: /jep/229
+  title: 'JEP-229: Continuous Delivery of Jenkins Components and Plugins'
+---
+


Roadmap-wise, an initiative is in preview until the respective JEP is formally accepted

daniel-beck · 2021-05-16T08:43:00Z

IMHO we have not yet reached a consensus whether we want to keep using GitHub actions in longer term

AFAICT there is consensus: Other than you, I've not seen anyone involved even tangentially who thinks this is a bad idea. And nobody has presented a plan how to make this work using Jenkins while the infra team is already under water.

jglick · 2021-05-17T15:13:18Z

nobody has presented a plan how to make this work using Jenkins

…even assuming availability of someone to work on it, since any hypothetical job on a secured server would need to be given limited permission not just to Artifactory but also to GitHub in order to update releases and invoke Release Drafter, introducing significant permission management issues. Could add more to https://github.com/jenkinsci/jep/tree/master/jep/229#github-actions as needed but I do not foresee this decision being revisited.

timja · 2021-05-19T07:30:43Z

@oleg-nenashev ping.

If no response in a couple of days I'll merge this.

no response, request for change rejected

Add CD guide for releasing plugins

ac14594

timja added the enhancement label May 9, 2021

timja requested review from jglick and daniel-beck May 9, 2021 21:59

timja requested a review from a team as a code owner May 9, 2021 21:59

probot-autolabeler bot added the documentation Jenkins documentation, including user and developer docs, solution pages, etc. label May 9, 2021

daniel-beck reviewed May 9, 2021

View reviewed changes

content/doc/developer/plugin-development/incrementals.adoc Outdated Show resolved Hide resolved

daniel-beck approved these changes May 10, 2021

View reviewed changes

timja commented May 10, 2021

View reviewed changes

content/doc/developer/publishing/releasing-cd.adoc Outdated Show resolved Hide resolved

Update content/doc/developer/publishing/releasing-cd.adoc

bc6180f

timja commented May 10, 2021

View reviewed changes

content/doc/developer/publishing/releasing-cd.adoc Outdated Show resolved Hide resolved

jglick approved these changes May 10, 2021

View reviewed changes

Apply suggestions from code review

87acffd

Co-authored-by: Jesse Glick <jglick@cloudbees.com>

timja commented May 10, 2021

View reviewed changes

content/doc/developer/publishing/releasing-cd.adoc Show resolved Hide resolved

Update content/doc/developer/publishing/releasing-cd.adoc

d617032

jglick reviewed May 10, 2021

View reviewed changes

content/doc/developer/publishing/releasing-cd.adoc Outdated Show resolved Hide resolved

This was referenced May 10, 2021

Link to jenkins.io for setting up JEP-229 jenkinsci/jep#360

Merged

Move docs to jenkins.io jenkinsci/incrementals-tools#20

Merged

Update content/doc/developer/publishing/releasing-cd.adoc

36f71f9

Co-authored-by: Jesse Glick <jglick@cloudbees.com>

oleg-nenashev suggested changes May 10, 2021

View reviewed changes

Update content/doc/developer/publishing/releasing-cd.adoc

e173424

Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>

timja requested a review from oleg-nenashev May 10, 2021 21:39

jglick approved these changes May 11, 2021

View reviewed changes

Update content/doc/developer/publishing/releasing-cd.adoc

82085fe

Co-authored-by: Jesse Glick <jglick@cloudbees.com>

timja commented May 11, 2021

View reviewed changes

content/doc/developer/publishing/releasing-cd.adoc Outdated Show resolved Hide resolved

Update content/doc/developer/publishing/releasing-cd.adoc

5ef3693

timja requested a review from olblak May 11, 2021 21:54

oleg-nenashev previously requested changes May 13, 2021

View reviewed changes

timja requested a review from oleg-nenashev May 14, 2021 10:19

timja merged commit a69026c into jenkins-infra:master May 21, 2021

timja deleted the migrate-cd-docs branch May 21, 2021 07:05

jglick mentioned this pull request Mar 7, 2022

Note when people may have gotten a bad release-drafter config #4965

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add CD guide for releasing plugins #4341

Add CD guide for releasing plugins #4341

timja commented May 9, 2021

daniel-beck left a comment

timja commented May 10, 2021

jglick left a comment

jglick May 10, 2021

timja May 10, 2021

olblak May 11, 2021

timja May 11, 2021 •

edited

Loading

jglick May 10, 2021

timja May 10, 2021

jglick May 10, 2021

daniel-beck May 10, 2021

jglick commented May 10, 2021

oleg-nenashev left a comment

oleg-nenashev May 10, 2021

timja May 10, 2021

jglick May 10, 2021

jglick May 11, 2021

oleg-nenashev May 13, 2021

timja May 14, 2021

oleg-nenashev May 15, 2021

timja May 16, 2021

oleg-nenashev May 10, 2021

timja May 10, 2021

oleg-nenashev May 13, 2021

jglick May 11, 2021

oleg-nenashev left a comment

oleg-nenashev May 13, 2021

daniel-beck commented May 16, 2021

jglick commented May 17, 2021

timja commented May 19, 2021


		=== Further troubleshooting help

		If none of the provided solutions help, send an email to the link:/mailing-lists[Jenkins developers mailing list] and explain what you did, and how it failed.


		For a regular component whose version number is not that meaningful:

		[source,diff]

+WARNING: Continuous Delivery of Jenkins Components and Plugin (jep:229[]) is currently in preview.
+See the referenced Jenkins enhancement proposal and references in it to see the current state.
+Any feedback from early adopters will be appreciated.



	NOTE: Continuous Delivery of Jenkins Components and Plugin (jep:229[]) is relatively new.
	Any feedback from early adopters will be appreciated.

Add CD guide for releasing plugins #4341

Add CD guide for releasing plugins #4341

Conversation

timja commented May 9, 2021

daniel-beck left a comment

Choose a reason for hiding this comment

timja commented May 10, 2021

jglick left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

timja May 11, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jglick commented May 10, 2021

oleg-nenashev left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oleg-nenashev left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daniel-beck commented May 16, 2021

jglick commented May 17, 2021

timja commented May 19, 2021

timja May 11, 2021 •

edited

Loading