Plat 249 reduce rerun time #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds logic for returning the total number of transactions to be rerun when a bulk rerun is being done PLAT-249
This is a refactor of the logic to reduce the time teken for a transaction to be rerun. Some redundant steps have been removed PLAT-249
This is a more efficient way of creating the bulk rerun tasks. Before the openhim console had to fetch transcation ids and then send them back to the openhim core for the creation of rerrun tasks. The openhim console only has to specify the query parameters for the transactions to be rerun and the core will handle the creation of the tasks.
Codecov Report
@@ Coverage Diff @@
## master #1165 +/- ##
=======================================
Coverage 85.02% 85.02%
=======================================
Files 77 77
Lines 5247 5310 +63
=======================================
+ Hits 4461 4515 +54
- Misses 786 795 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Failed build = 🍰 |
michaelloosen
suggested changes
Oct 7, 2022
The projection was incorrect and causing some tests to fail
Should be version 7.1.0 not 7.2.0
This is so we dont have memory issues when a lot of transactions are being rerun
To increase the code coverage
This is so we dont overflow the stack when there are lot of transactions being rerun.
…sactiosn to rerun
marrouchi
suggested changes
Oct 27, 2022
Co-authored-by: Mohamed Marrouchi <marrouchi.mohamed@gmail.com>
marrouchi
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.