Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cu 86bz9pz5f save common fields to local storage #263
Cu 86bz9pz5f save common fields to local storage #263
Changes from 8 commits
fb3a2b6
d263884
f83850b
fb12606
adc3916
2e8815f
ca18740
6fb1f36
41d0eff
351d61a
9764098
3387e18
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactor
toSnakeCase
function to handle additional cases.The function currently handles spaces and camelCase to snake_case conversion. Consider adding support for other cases such as kebab-case and removing special characters that are not typically used in identifiers.
Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure consistent handling of
rowFocusOut
reason.The
handleRowEditStop
function checks if the reason isGridRowEditStopReasons.rowFocusOut
but does not setevent.defaultMuiPrevented = true
. Ensure consistency across the codebase by updating the implementation.Committable suggestion