Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JMPI-742-update-notification-component #137

Merged
merged 47 commits into from
Jan 8, 2024

Conversation

issambaccouch
Copy link
Contributor

No description provided.

@issambaccouch issambaccouch marked this pull request as draft October 31, 2023 17:28
@issambaccouch issambaccouch self-assigned this Oct 31, 2023
@issambaccouch issambaccouch force-pushed the JMPI-742-update-notification-component branch 4 times, most recently from 13dfcb9 to 0060da7 Compare November 8, 2023 16:19
@issambaccouch issambaccouch marked this pull request as ready for review November 14, 2023 13:18
@issambaccouch issambaccouch force-pushed the JMPI-742-update-notification-component branch from 434e8f2 to 7b4d27a Compare November 15, 2023 17:05
@issambaccouch issambaccouch requested a review from walisc December 15, 2023 19:26
Copy link
Collaborator

@walisc walisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ajinkyagadewar . Have reviewed this, and it looks generally fine. Made some minor updates if you want to have a look, else keen to get the merged as the M and U ui items depend on this branch.

@walisc
Copy link
Collaborator

walisc commented Jan 5, 2024

Also, thanks for the work done on this @issambaccouch ! Like intergration of the ui dev mode to the docker swarm, and the record fetching optimizations! Quite cool! 🙏🏽

@walisc walisc merged commit 404baa0 into dev Jan 8, 2024
@walisc walisc deleted the JMPI-742-update-notification-component branch January 8, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants