-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jempi base keycloak login UI updates #127
Jempi base keycloak login UI updates #127
Conversation
@ajinkyagadewar if you also want to have a look. |
Hi @issambaccouch. Have updated this based on your comments above. |
Hi @issambaccouch. Have now resolved the merge conflicts on this (and tested). Could you please merge it, as I need it for #132. Many thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@walisc Great work Chidow.
Ticket: N/A
Other Related Tickets: N/A
Describe of changes
This change adds keyclock login abilities to the JEMPI_UI app. When Single Sign On (SSO) is enabled, the user will need to authenticate themselve via the configured keyclock instance (see below)
login.mp4
In addition to this, this pull request also
Future considerations
Currently you can set
REACT_APP_MOCK_BACKEND
to true in theenv
file. This uses a statically mocked version of the api version. As there is now a mock API server for testing (above), this code can be moved there, as removed from the src folder. This also helps improve security as the tests folder is not bundled with the final app.How to test
npm run mock:enviroments
(this will start both the MockJeMPI_API and the MockKeyCloak Servers)npm run start
to start the app