Jmpi 702 implementing jempi dashboard #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issambaccouch
force-pushed
the
JMPI-702-implementing-jempi-dashboard
branch
from
6e7e698 to
8521fbc
Compare
|
Hi @issambaccouch . This looks good. Is it still work in progress? |
@walisc yes it's draft |
issambaccouch
force-pushed
the
JMPI-702-implementing-jempi-dashboard
branch
2 times, most recently
from
b64aa4a to
0998ed7
Compare
issambaccouch
force-pushed
the
JMPI-702-implementing-jempi-dashboard
branch
from
0998ed7 to
8b514ab
Compare
walisc
reviewed
Nov 1, 2023
walisc
reviewed
Nov 1, 2023
walisc
reviewed
Nov 1, 2023
walisc
reviewed
Nov 1, 2023
JeMPI_Apps/JeMPI_UI/src/components/dashboard/widgets/ConfusionMatrixWidget.tsx
Show resolved
Hide resolved
walisc
reviewed
Nov 1, 2023
JeMPI_Apps/JeMPI_UI/src/components/dashboard/widgets/ConfusionMatrixWidget.tsx
Show resolved
Hide resolved
walisc
reviewed
Nov 1, 2023
JeMPI_Apps/JeMPI_UI/src/components/dashboard/widgets/ConfusionMatrixWidget.tsx
Show resolved
Hide resolved
walisc
reviewed
Nov 1, 2023
JeMPI_Apps/JeMPI_UI/src/components/dashboard/widgets/ConfusionMatrixWidget.tsx
Show resolved
Hide resolved
walisc
reviewed
Nov 1, 2023
walisc
reviewed
Nov 1, 2023
JeMPI_Apps/JeMPI_UI/src/components/dashboard/widgets/CountWidgetWidget.tsx
Show resolved
Hide resolved
|
Hi @issambaccouch . Thanks for this! Just have a few comments needing clarity (above). Besides that, looking good! |
walisc
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.