Fix bug in ControlValue (#25)

jelmersnoeck · Dec 20, 2019 · 9f66c77 · 9f66c77
1 parent 7696af0
commit 9f66c77
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 13 deletions.
diff --git a/experiment.go b/experiment.go
@@ -196,6 +196,16 @@ func (e *Experiment) runSequential(cChan chan *Observation) {
 func (e *Experiment) conclude() {
 	control := e.observations["control"]
 
+	for _, o := range e.observations {
+		if o.Error == nil {
+			if e.clean != nil {
+				o.CleanValue = e.clean(o.Value)
+			} else {
+				o.CleanValue = o.Value
+			}
+		}
+	}
+
 	if e.compare != nil {
 		for k, o := range e.observations {
 			if o.Error == nil {
@@ -205,21 +215,11 @@ func (e *Experiment) conclude() {
 				}
 
 				o.Success = e.compare(control.Value, o.Value)
+				o.ControlValue = control.CleanValue
 			}
 		}
 	}
 
-	for _, o := range e.observations {
-		if o.Error == nil {
-			if e.clean != nil {
-				o.CleanValue = e.clean(o.Value)
-			} else {
-				o.CleanValue = o.Value
-			}
-		}
-		o.ControlValue = control.CleanValue
-	}
-
 	if e.Config.Publisher != nil {
 		for _, o := range e.observations {
 			e.Config.Publisher.Publish(*o)

diff --git a/experiment_test.go b/experiment_test.go
@@ -56,8 +56,7 @@ func TestRun_Sequential(t *testing.T) {
 
 	t.Run("it should record the clean control", func(t *testing.T) {
 		pub.fnc = func(o experiment.Observation) {
-			if o.Name != "control" {
-				fmt.Printf("%+v\n", o)
+			if o.Name != "control" && o.Error == nil {
 				if o.Panic == nil && o.ControlValue.(string) != "Cleaned control" {
 					t.Errorf("Expected value to be '%s', got '%s'", "Cleaned Control", o.ControlValue.(string))
 				}