Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.12 to the testing #1251

Merged
merged 4 commits into from
Jan 24, 2024
Merged

Add Python 3.12 to the testing #1251

merged 4 commits into from
Jan 24, 2024

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jan 24, 2024

No description provided.

@cclauss cclauss requested a review from jelmer as a code owner January 24, 2024 19:56
Copy link
Owner

@jelmer jelmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests seem to be failing due to missing setuptools?

@cclauss
Copy link
Contributor Author

cclauss commented Jan 24, 2024

https://docs.python.org/3/whatsnew/3.12.html

PEP 632: Remove the distutils package. See the migration guide for advice replacing the APIs it provided. The third-party Setuptools package continues to provide distutils, if you still require it in Python 3.12 and beyond.

pyproject.toml: dependencies = ['setuptools ; python_version >= "3.12"']

@jelmer jelmer enabled auto-merge January 24, 2024 20:29
@cclauss
Copy link
Contributor Author

cclauss commented Jan 24, 2024

Magic ;-)

@jelmer jelmer merged commit 75a95f4 into jelmer:master Jan 24, 2024
19 checks passed
@cclauss cclauss deleted the patch-2 branch January 24, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants