Downgrade to React 17 #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+4
to
+12
| { | ||
| "description": "Disable major updates for React", | ||
| "matchPackagePrefixes": ["react"], | ||
| "matchPackageNames": ["@types/react", "@types/react-helmet", "@types/react-router-dom"], | ||
| "matchUpdateTypes": "major", | ||
| "enabled": false | ||
| } | ||
| ] |
There was a problem hiding this comment.
Do we never want to get React updates from Renovate or just skip React 18? Closing a Renovate update PR just skips a single specific version.
There was a problem hiding this comment.
I believe any major updates for React will require support in docusaurus first.
nielsvanvelzen
approved these changes
Aug 5, 2022
tannisroot
pushed a commit
to tannisroot/jellyfin.org
that referenced
this pull request
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docusaurus has not migrated to React 18 yet. While it doesn't really seem to cause any issues, it does log an error, and it is explicitly not supported for some plugins (specifically the redirect plugin I was looking at).
The lockfile was bumped to the v2 format which should be fine here since we are using node 16.
Also I have no idea why prettier is randomly removing trailing newlines in json files, but it's kind of annoying...It seems VS Code formatting on save is enabled, but is not using prettier and it's formatting removes trailing newlines and makes other changes that do not align with the prettier config.