Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mixed and collection library icons #6082

Merged
merged 5 commits into from
Sep 21, 2024
Merged

Update mixed and collection library icons #6082

merged 5 commits into from
Sep 21, 2024

Conversation

thornbill
Copy link
Member

Changes

  • Updates the icons for mixed libraries and collections
New Old
Screenshot 2024-09-17 at 12-39-00 Jellyfin Screenshot 2024-09-17 at 12-51-30 Jellyfin

Issues
N/A

@thornbill thornbill added enhancement Improve existing functionality or small fixes ui & ux This PR or issue mainly concerns UI & UX labels Sep 17, 2024
@thornbill thornbill added this to the v10.10.0 milestone Sep 17, 2024
@thornbill thornbill requested a review from a team as a code owner September 17, 2024 17:38
@dmitrylyzo
Copy link
Contributor

Experimental only?

jellyfin-web/src/utils/image.ts

Line 78 in 1564c93

export function getLibraryIcon(library: string | null | undefined) {

jellyfin-web/src/utils/image.ts

Line 107 in 1564c93

export function getItemTypeIcon(itemType: BaseItemKind | string) {

jellyfin-web/src/components/cardbuilder/cardBuilder.js

Line 1182 in 1564c93

export function getDefaultText(item, options) {

@thornbill
Copy link
Member Author

Good call @dmitrylyzo! They should be consistent now.

dmitrylyzo
dmitrylyzo reviewed Sep 17, 2024
View reviewed changes
src/utils/image.ts Outdated Show resolved Hide resolved
src/utils/image.ts Outdated Show resolved Hide resolved
src/utils/image.ts Outdated Show resolved Hide resolved
src/utils/image.ts Outdated Show resolved Hide resolved
thornbill and others added 2 commits September 17, 2024 17:33
@thornbill @dmitrylyzo
Use consistent icon names
cd14a6b 
Co-authored-by: Dmitry Lyzo <56478732+dmitrylyzo@users.noreply.github.com>
@thornbill
Fix default icon handling and add tests
2abc648
@thornbill thornbill changed the title Update mixed and collection libraries Update mixed and collection library icons Sep 18, 2024
grafixeyehero
grafixeyehero reviewed Sep 20, 2024
View reviewed changes
src/utils/image.ts Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit 46c6fd4b85ee7ec92edc8d9582d6c862d106955b
Status ✅ Deployed!
Preview URL https://4b2df6b0.jellyfin-web.pages.dev
Type 🔀 Preview

@thornbill thornbill merged commit 23ee5e6 into jellyfin:master Sep 21, 2024
12 checks passed
@thornbill thornbill deleted the mixed-icon branch September 21, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitrylyzo dmitrylyzo dmitrylyzo left review comments

@grafixeyehero grafixeyehero grafixeyehero approved these changes

Assignees
No one assigned
Labels
enhancement Improve existing functionality or small fixes ui & ux This PR or issue mainly concerns UI & UX
Projects
Jellyfin 10.10
Status: Done
Milestone
v10.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@thornbill @dmitrylyzo @jellyfin-bot @grafixeyehero