Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show slideshow controls when touched #6016

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Show slideshow controls when touched #6016

merged 1 commit into from
Sep 4, 2024

Conversation

tcely
Copy link
Contributor

@tcely tcely commented Sep 4, 2024

It appears that a previous commit changed the blocks so that only mouse events were recognized.

Changes

Moved the showOsd call outside of the "mouse" block.

Issues

@tcely
slideshow: show controls when touched
455db67 
It appears that a previous commit changed the blocks so that only mouse events were recognized.
@tcely tcely requested a review from a team as a code owner September 4, 2024 00:14
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@tcely tcely mentioned this pull request Sep 4, 2024
Closed
@thornbill thornbill added the bug Something isn't working label Sep 4, 2024
@thornbill thornbill changed the title slideshow: show controls when touched Show slideshow controls when touched Sep 4, 2024
@thornbill thornbill added enhancement Improve existing functionality or small fixes stable backport Backport into the next stable release and removed bug Something isn't working labels Sep 4, 2024
@thornbill thornbill added this to the v10.9.11 milestone Sep 4, 2024
thornbill
thornbill approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@thornbill thornbill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to have always worked this way. It shouldn't be an issue on mobile since the controls are always visible there, but it likely wouldn't have worked properly on computers with touchscreen monitors.

@thornbill thornbill merged commit 2682098 into jellyfin:release-10.9.z Sep 4, 2024
9 checks passed
@tcely
Copy link
Contributor Author

tcely commented Sep 4, 2024

It shouldn't be an issue on mobile since the controls are always visible there, but it likely wouldn't have worked properly on computers with touchscreen monitors.

I can confirm that on mobile, both the app and browser, on my phone the controls disappear when you pause and they do not return.

@tcely tcely deleted the patch-2 branch September 4, 2024 17:04
joshuaboniface pushed a commit that referenced this pull request Sep 7, 2024
@tcely @joshuaboniface
Backport pull request #6016 from jellyfin-web/release-10.9.z
2aabb13 
Show slideshow controls when touched

Original-merge: 2682098

Merged-by: thornbill <thornbill@users.noreply.github.com>

Backported-by: Joshua M. Boniface <joshua@boniface.me>
@jellyfin-bot jellyfin-bot removed the stable backport Backport into the next stable release label Sep 7, 2024
@tcely
Copy link
Contributor Author

tcely commented Sep 11, 2024

Controls now appear in 10.9.11 as expected. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thornbill thornbill thornbill approved these changes

Assignees
No one assigned
Labels
enhancement Improve existing functionality or small fixes
Projects
No open projects
Release 10.9.z
Status: Done
Milestone
v10.9.11
Development

Successfully merging this pull request may close these issues.
3 participants
@tcely @thornbill @jellyfin-bot