Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Safari volume control #5920

Merged
merged 1 commit into from
Aug 17, 2024

Conversation

gnattu
Copy link
Member

@gnattu gnattu commented Aug 17, 2024

Our audio normalization gain node does not consider the webkit implementation where the gain is an absolute volume value, causing the volume not be able to be changed as the gain is always locked to a pre-defined value even the normalization has being disabled. This multiplies the volume value to the defined gain value ratio to control the final volume on Safari.

This also hides the volume slider on iPads because it will not work, and is not detected by browser.mobile.

Changes

  • Fixes volume control on Safari where the gain value is an absolute value
  • Hide volume slider on iPad because it will not work and cannot be detected by browser.mobile

Issues

Fixes #5758

@gnattu gnattu requested a review from a team as a code owner August 17, 2024 02:46
Copy link

sonarcloud bot commented Aug 17, 2024

@thornbill thornbill added bug Something isn't working regression We broke something stable backport Backport into the next stable release labels Aug 17, 2024
@thornbill thornbill added this to the v10.9.10 milestone Aug 17, 2024
@thornbill thornbill merged commit 90236c2 into jellyfin:release-10.9.z Aug 17, 2024
11 checks passed
@gnattu gnattu deleted the fix-safari-volume-10.9 branch August 17, 2024 17:57
joshuaboniface pushed a commit that referenced this pull request Aug 25, 2024
Fix Safari volume control

Original-merge: 90236c2

Merged-by: thornbill <thornbill@users.noreply.github.com>

Backported-by: Joshua M. Boniface <joshua@boniface.me>
@jellyfin-bot jellyfin-bot removed the stable backport Backport into the next stable release label Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression We broke something
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants