Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invisible headings #5776

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

thornbill
Copy link
Member

Changes
I don't really understand why, but for some reason the backdrop container seems to display over MUI heading elements in the experimental layout. Reverting the z-index change in #5640 caused the text to disappear (again this was caught in the PR for the user display settings page initially). Setting position: relative on the main app layout element seems to fix the issue without messing with z-index.

Before After
Screenshot 2024-07-12 at 15-45-38 Display Screenshot 2024-07-12 at 15-46-23 Display

Issues
N/A

@thornbill thornbill added bug Something isn't working regression We broke something labels Jul 12, 2024
@thornbill thornbill added this to the v10.9.8 milestone Jul 12, 2024
@thornbill thornbill requested a review from a team as a code owner July 12, 2024 19:53
@thornbill thornbill added the stable backport Backport into the next stable release label Jul 12, 2024
@thornbill thornbill merged commit 9e7ad28 into jellyfin:release-10.9.z Jul 12, 2024
8 checks passed
@thornbill thornbill deleted the fix-invisible-headings branch July 12, 2024 20:14
@jellyfin-bot jellyfin-bot removed the stable backport Backport into the next stable release label Jul 21, 2024
joshuaboniface pushed a commit that referenced this pull request Jul 21, 2024
Fix invisible headings

Original-merge: 9e7ad28

Merged-by: thornbill <thornbill@users.noreply.github.com>

Backported-by: Bill Thornton <thornbill@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression We broke something
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants