Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prioritise HEVC over H264 in HLS TS streams on webOS #5621

Merged

Conversation

FintasticMan
Copy link
Contributor

Changes
Moved the HEVC codec higher in the priority ranking over H264 when transcoding to an HLS stream in a TS container.

Issues
None

@FintasticMan FintasticMan requested a review from a team as a code owner May 28, 2024 22:02
@scampower3
Copy link
Member

Perhaps it might be better if it is user configurable setting like #5434

@dmitrylyzo
Copy link
Contributor

I don't see any problem with prioritizing HEVC for Tizen as well. Anyway, it is up to the server to make the final decision.
For audio, I tried a different approach to not making big changes (codecs are in reversed order).

@FintasticMan
Copy link
Contributor Author

I think that it might be good to simply prioritise HEVC for 10.9, and then add user-configuration for 10.10. What do you think?

Copy link

sonarcloud bot commented May 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@scampower3 scampower3 added this to the v10.9.5 milestone Jun 5, 2024
@thornbill thornbill added enhancement Improve existing functionality or small fixes p: webos This PR or issue mainly concerns WebOS clients p: tizen This PR or issue mainly concerns Tizen clients labels Jun 5, 2024
@thornbill thornbill merged commit 7865170 into jellyfin:release-10.9.z Jun 5, 2024
11 checks passed
@FintasticMan FintasticMan deleted the webos_prioritise_hevc branch June 5, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality or small fixes p: tizen This PR or issue mainly concerns Tizen clients p: webos This PR or issue mainly concerns WebOS clients
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants