Add support for user themes for mui components #5589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thornbill
commented
May 23, 2024
| @@ -21,12 +19,10 @@ const RootApp = ({ history }: Readonly<{ history: History }>) => { | |||
| <QueryClientProvider client={queryClient}> | |||
| <ApiProvider> | |||
| <WebConfigProvider> | |||
| <ThemeProvider theme={theme}> | |||
There was a problem hiding this comment.
The theme provider had to be moved to have access to the useLocation hook to be able to determine if the user is on a dashboard page.
|
nielsvanvelzen
approved these changes
May 25, 2024
scampower3
approved these changes
May 25, 2024
joshuaboniface
pushed a commit
that referenced
this pull request
May 26, 2024
Add support for user themes for mui components Original-merge: 61976b8 Merged-by: thornbill <thornbill@users.noreply.github.com> Backported-by: Joshua M. Boniface <joshua@boniface.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Currently changing to a light theme (appletv or light) will produce white text on a white background
We can move this out if it is too big for a backport 🤷♂️
Issues
Part of #4815