Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scheduled task dialog z-index #5530

Merged
merged 1 commit into from
May 17, 2024
Merged

Fix scheduled task dialog z-index #5530

merged 1 commit into from
May 17, 2024

Conversation

thornbill
Copy link
Member

Changes

  • Fixes the z-index of the add scheduled task trigger dialog so the dialog renders over other ui components. This z-index value matches what is used for dialog containers in other areas of the app.

Issues
Fixes #5522

@thornbill thornbill added bug Something isn't working regression We broke something stable backport Backport into the next stable release labels May 17, 2024
@thornbill thornbill added this to the v10.9.2 milestone May 17, 2024
@thornbill thornbill requested a review from a team as a code owner May 17, 2024 16:37
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit 1e035d5
Status ✅ Deployed!
Preview URL https://92e62edc.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs
View bot logs

@thornbill thornbill merged commit 3402f1b into jellyfin:release-10.9.z May 17, 2024
10 checks passed
@thornbill thornbill deleted the fix-schedule-dialog branch May 17, 2024 17:09
joshuaboniface pushed a commit that referenced this pull request May 17, 2024
@thornbill @joshuaboniface
Backport pull request #5530 from jellyfin-web/release-10.9.z
291d309 
Fix scheduled task dialog z-index

Original-merge: 3402f1b

Merged-by: thornbill <thornbill@users.noreply.github.com>

Backported-by: Joshua M. Boniface <joshua@boniface.me>
@jellyfin-bot jellyfin-bot removed the stable backport Backport into the next stable release label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsvanvelzen nielsvanvelzen nielsvanvelzen approved these changes

@Bond-009 Bond-009 Bond-009 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working regression We broke something
Projects
No open projects
Release 10.9.z
Status: Done
Milestone
v10.9.2
Development

Successfully merging this pull request may close these issues.
4 participants
@thornbill @jellyfin-bot @nielsvanvelzen @Bond-009