Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link documentation in fallback fonts helptext #4863

Merged
merged 5 commits into from
Oct 18, 2023

Conversation

felix920506
Copy link
Member

This PR intends to document where fallback fonts are used in Jellyfin within the web client.

related issues:
jellyfin/#5008
jellyfin/#9273

@felix920506 felix920506 requested a review from a team as a code owner October 9, 2023 18:01
@thornbill thornbill added the enhancement Improve existing functionality or small fixes label Oct 15, 2023
Copy link
Member

@thornbill thornbill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should really avoid having html in translations. I think the best option would be to have the documentation link be separate from the help text, so the html for the link can be part of the code. Maybe just "Read the documentation" or "Read more"?

@felix920506
Copy link
Member Author

I have moved the link into code. I will open a PR on web as well since there are some things that aren't there but was in this string before.

src/strings/en-us.json Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
2.0% 2.0% Duplication

@thornbill thornbill added this to the v10.9.0 milestone Oct 18, 2023
@thornbill thornbill merged commit 61f56f9 into jellyfin:master Oct 18, 2023
22 checks passed
@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit f875e2b
Status ✅ Deployed!
Preview URL https://59f5f3d9.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs
View bot logs

@felix920506 felix920506 deleted the document-fallback-fonts branch October 22, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality or small fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants