Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Textarea Behavior #4845

Closed
wants to merge 13 commits into from
Closed

Improve Textarea Behavior #4845

Changes from 3 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
22c9f04
Improve textarea behavior
Sukhendu2002 Oct 5, 2023
c225a5b
Merge branch 'jellyfin:master' into master
Sukhendu2002 Oct 5, 2023
ef930af
Merge branch 'master' into textarea-improvements
Sukhendu2002 Oct 6, 2023
fe261bb
Add trim on blur
Sukhendu2002 Oct 6, 2023
5bf64e7
Merge branch 'master' into textarea-improvements
Sukhendu2002 Oct 7, 2023
4fa4f52
Fix extra line problem
Sukhendu2002 Oct 7, 2023
2c6db28
Merge branch 'textarea-improvements' of https://github.com/Sukhendu20…
Sukhendu2002 Oct 7, 2023
65f8e94
Merge branch 'master' into textarea-improvements
Sukhendu2002 Oct 7, 2023
61dc80f
Merge branch 'master' into textarea-improvements
Sukhendu2002 Oct 8, 2023
6717db4
Merge branch 'master' into textarea-improvements
Sukhendu2002 Oct 9, 2023
ef6afeb
Merge branch 'master' into textarea-improvements
Sukhendu2002 Oct 10, 2023
5490825
Merge branch 'master' into textarea-improvements
Sukhendu2002 Oct 12, 2023
0470776
Merge branch 'master' into textarea-improvements
Sukhendu2002 Nov 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions src/elements/emby-textarea/emby-textarea.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,16 +52,36 @@ function AutoGrow(textarea, maxLines) {
newHeight = self.maxAllowedHeight;
} else {
textarea.style.overflowY = 'hidden';
textarea.style.height = 'auto';
// textarea.style.height = 'auto';
newHeight = textarea.scrollHeight/* - offset*/;
}
textarea.style.height = newHeight + 'px';
}

// Call autogrowFn() when textarea's value is changed
textarea.addEventListener('input', autogrowFn);
textarea.addEventListener('input', function() {
autogrowFn();
if (textarea.value.trim() === '') {
textarea.style.height = 'auto';
}
});
textarea.addEventListener('focus', autogrowFn);
dmitrylyzo marked this conversation as resolved.
Show resolved Hide resolved
textarea.addEventListener('valueset', autogrowFn);
textarea.addEventListener('keydown', function(event) {
if (event.key === 'Enter') {
const currentCursorPosition = textarea.selectionStart;
const textBeforeCursor = textarea.value.substring(0, currentCursorPosition);
const textAfterCursor = textarea.value.substring(currentCursorPosition);

const newTextValue = textBeforeCursor + '\n' + textAfterCursor;
textarea.value = newTextValue;

const newCursorPosition = currentCursorPosition + 1;
textarea.setSelectionRange(newCursorPosition, newCursorPosition);

autogrowFn();
}
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doubles the new lines and seems unnecessary.
Or maybe I haven't found the steps to reproduce what it is supposed to fix. 🤷‍♂️

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we add a new line in the text area the text jumps to the top of the screen, it is supposed to fix that.

2023-10-06.17-22-22.mp4

Copy link
Contributor

@dmitrylyzo dmitrylyzo Oct 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't jump without keydown in Chrome and Firefox. 🤷‍♂️

UPD:
Ahh, after pasting a big wall of text it starts jumping.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, it is pretty much done

Copy link
Contributor

@dmitrylyzo dmitrylyzo Oct 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Writing by memory

        if ((textarea.scrollHeight - offset) > self.maxAllowedHeight) {
            textarea.style.overflowY = 'scroll';
            newHeight = self.maxAllowedHeight;
        } else {
            textarea.style.overflowY = 'hidden';
            stub.style.height = textarea.style.height;
            textarea.style.height = 'auto';    // to shrink the textarea
            newHeight = textarea.scrollHeight;
        }
        textarea.style.height = newHeight + 'px';
        stub.style.height = '0px';    // here is an error in the reference comment

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still getting the jumping problem

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still getting the jumping problem

On shrinking (deleting text) or on growing (adding text)?
The stub hack is for shrinking. I tried with your keydown hack.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on growing

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have this change with the current state of your branch.

diff --git a/src/elements/emby-textarea/emby-textarea.js b/src/elements/emby-textarea/emby-textarea.js
index 80e79e115..3189cc22f 100644
--- a/src/elements/emby-textarea/emby-textarea.js
+++ b/src/elements/emby-textarea/emby-textarea.js
@@ -19,7 +19,7 @@ function calculateOffset(textarea) {
     return offset;
 }
 
-function AutoGrow(textarea, maxLines) {
+function AutoGrow(textarea, stub, maxLines) {
     const self = this;
 
     if (maxLines === undefined) {
@@ -52,19 +52,17 @@ function AutoGrow(textarea, maxLines) {
             newHeight = self.maxAllowedHeight;
         } else {
             textarea.style.overflowY = 'hidden';
-            // textarea.style.height = 'auto';
+            stub.style.height = textarea.style.height;
+            textarea.style.height = 'auto';
             newHeight = textarea.scrollHeight/* - offset*/;
         }
         textarea.style.height = newHeight + 'px';
+        stub.style.height = '0px';
     }
 
     // Call autogrowFn() when textarea's value is changed
     textarea.addEventListener('input', autogrowFn);
     textarea.addEventListener('focus', autogrowFn);
-    textarea.addEventListener('blur', () => {
-        textarea.style.height = 'auto';
-        autogrowFn();
-    });
     textarea.addEventListener('valueset', autogrowFn);
     textarea.addEventListener('keydown', function(event) {
         if (event.key === 'Enter') {
@@ -132,6 +130,9 @@ EmbyTextAreaPrototype.attachedCallback = function () {
     label.htmlFor = this.id;
     parentNode.insertBefore(label, this);
 
+    const stub = this.ownerDocument.createElement('div');
+    parentNode.insertBefore(stub, this.nextSibling);
+
     this.addEventListener('focus', function () {
         label.classList.add('textareaLabelFocused');
         label.classList.remove('textareaLabelUnfocused');
@@ -145,7 +146,7 @@ EmbyTextAreaPrototype.attachedCallback = function () {
         label.innerText = text;
     };
 
-    new AutoGrow(this);
+    new AutoGrow(this, stub);
 };
 
 document.registerElement('emby-textarea', {

But I noticed that the focus doesn't follow the cursor on Enter, when it is at the bottom of the window.

Also, the cursor can hide under the top bar. But this is another story.


autogrowFn();
}
Expand Down