Eliminates critical Cognitive Complexity issue in Card Builder component as detected by SonarCloud #4829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddubson
force-pushed
the
ddubson/cards-html-gen-smell
branch
2 times, most recently
from
6b7443b
to
a45556b
Compare
thornbill
requested changes
Oct 5, 2023
Adds two new npm scripts: - 'test' - runs test suite once and exits - 'test:watch' - runs test suite perpetually. Any file suffixed with '.test.[js|ts]' is considered a test suite
ddubson
force-pushed
the
ddubson/cards-html-gen-smell
branch
from
a45556b
to
293fddf
Compare
…tive complexity Fixes jellyfingh-4828
ddubson
force-pushed
the
ddubson/cards-html-gen-smell
branch
from
293fddf
to
d77d69b
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
thornbill
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates Cognitive Complexity issue as detected by SonarCloud as a code smell of Critical severity.
Changes
npm testto GH Actions for Typescript checking, however running of the test suite may be a new workflow altogether. To reduce the amount of changes, the test suite execution is tacked on to an existing Action.getDesiredAspectandgetPostersPerRowfunctions out ofcardBuilder.jscomponent. The new filecardBuilderUtils.jsmay not have the best name -- this can be renamed as needed.Issues
Fixes gh-4828
https://sonarcloud.io/issues?resolved=false&open=AYry7wqGV85IQSFBo_VD