Add loading indicator and no results message for search #4824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JPVenson
suggested changes
Oct 2, 2023
JPVenson
approved these changes
Oct 2, 2023
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
thornbill
reviewed
Oct 5, 2023
with native <Loading />
thornbill
requested changes
Oct 11, 2023
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
|
Seems to be all good to go |
thornbill
requested changes
Oct 18, 2023
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
Change SearchResultsEmpty to have a substitution Co-authored-by: Bill Thornton <thornbill@users.noreply.github.com>
Update SearchResults Co-authored-by: Bill Thornton <thornbill@users.noreply.github.com>
thornbill
reviewed
Oct 20, 2023
Oops! Co-authored-by: Bill Thornton <thornbill@users.noreply.github.com>
thornbill
reviewed
Oct 24, 2023
Co-authored-by: Bill Thornton <thornbill@users.noreply.github.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Cloudflare Pages deployment
|
thornbill
approved these changes
Oct 24, 2023
thornbill
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves a search not returning anything with some text. A loading circle was also added in case search takes a long while.
Changes
Text added. Example:
Loading circle added (may be hard to spot since search is fast)
Feedback is more than welcome!
Recording.2023-10-01.181554.mp4