New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor app layouts and common components #4806

Merged

thornbill merged 2 commits into jellyfin:master from thornbill:common-component-refactor

Sep 29, 2023

Member

thornbill commented Sep 27, 2023 •

edited

Loading

Changes
This is mostly prep for splitting the dashboard to a separate "app".

Layouts are restructured so common components are not duplicated in the different apps.
Shared components are moved to src/components from the experimental app directory.
The mui theme is moved to src/themes.
Redirects are moved so they do not "render" within app layouts.

I'm trying to breakdown the dashboard changes so they are less huge.

Issues
N/A


          Refactor app layouts and common components

44678a6

thornbill added the cleanup label

thornbill added this to the v10.9.0 milestone

thornbill requested a review from a team as a code owner

September 27, 2023 06:18

grafixeyehero reviewed

View reviewed changes

src/RootApp.tsx Outdated Show resolved Hide resolved


          Move stable app to loadable

459681a

sonarcloud bot commented Sep 29, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
1.6% Duplication

grafixeyehero approved these changes

View reviewed changes

thornbill merged commit 0d5b974 into jellyfin:master

19 checks passed

thornbill deleted the common-component-refactor branch

October 5, 2023 18:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup