Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain what LUFS scanning does. #4792

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

KucharczykL
Copy link
Contributor

@KucharczykL KucharczykL commented Sep 20, 2023

Original description:


Hello! I found out about the audio normalization feature by translating the new strings at Weblate and just wanted to share a piece of feedback.

I find audio normalization to be highly desirable so I think the description of the LUFS scan feature should explain what it does so that people will consider turning it on. Even something as simple as saying that it's useful for audio normalization might be enough IMO.


Wording updated based on suggestion from @nielsvanvelzen

Changes
Changed description of LUFS.

Issues
Replaces #4647

@KucharczykL KucharczykL requested a review from a team as a code owner September 20, 2023 08:14
@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thornbill thornbill merged commit 46bb8cb into jellyfin:master Sep 21, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants