Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Album gain #4741

Merged
merged 15 commits into from
Oct 18, 2023
Merged

Album gain #4741

merged 15 commits into from
Oct 18, 2023

Conversation

TelepathicWalrus
Copy link
Contributor

@TelepathicWalrus TelepathicWalrus commented Aug 5, 2023 •
edited
Loading

Front end to use album gain. Changed audio normalization from checkbox to dropdown allowing the selection of either "off", "track gain" or "album gain".

Changes
Added support for album gain

Backend: jellyfin/jellyfin#10085

@TelepathicWalrus TelepathicWalrus requested a review from a team as a code owner August 5, 2023 13:25
@TelepathicWalrus TelepathicWalrus mentioned this pull request Aug 5, 2023
Merged
@TelepathicWalrus TelepathicWalrus force-pushed the album-gain branch 2 times, most recently from 63f68fa to 1ad4575 Compare August 11, 2023 20:10
@TelepathicWalrus
Copy link
Contributor Author

Feature has been merged into jellyfin master branch. This is required for use of feature. If someone could review so I/we can make changes as required

@thornbill thornbill added the feature New feature or request label Sep 8, 2023
@thornbill thornbill added this to the v10.9.0 milestone Sep 8, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.3% 5.3% Duplication

@thornbill
Copy link
Member

Sorry for the delay! I was taking a little break from working on this project.

I've merged in the latest from master now so we can see how CI goes.

@thornbill
Copy link
Member

Apologies for the delay (again)... it seems I have been accidentally overlooking this PR while reviewing 😅

@TelepathicWalrus
Copy link
Contributor Author

Apologies for the delay (again)... it seems I have been accidentally overlooking this PR while reviewing 😅

No problem. I have updated to use translatable strings. Unfortunately I have not tested yet as my work computer can't compile for some reason ATM. If you could check that would be great, if not I'll do it when I get home.

Thanks!

thornbill
thornbill requested changes Oct 16, 2023
View reviewed changes
Copy link
Member

@thornbill thornbill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple minor points of feedback.

(Also you can now test PRs on Cloudflare Pages using the automatic deployment linked in the comment above. 🚀)

src/plugins/htmlAudioPlayer/plugin.js Outdated Show resolved Hide resolved
src/plugins/htmlAudioPlayer/plugin.js Outdated Show resolved Hide resolved
src/strings/en-us.json Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Oct 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
2.6% 2.6% Duplication

@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit e249988
Status ✅ Deployed!
Preview URL https://426160d3.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs
View bot logs

@thornbill thornbill merged commit c2ec479 into jellyfin:master Oct 18, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thornbill thornbill thornbill approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
v10.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@TelepathicWalrus @thornbill @jellyfin-bot