Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Skia version to 1.68.1 #3

Merged
merged 3 commits into from
Mar 28, 2020
Merged

Conversation

jairbubbles
Copy link
Contributor

@jairbubbles jairbubbles commented Mar 27, 2020

Please note that the NuGet package still needs to be generated and pushed to nuget.org. This PR is only the easy part :-D

I guess we'll need to wait on @EraYaN

Fixes #2

@jairbubbles
Copy link
Contributor Author

Using docker to build was working fine but I first tried to use WSL which was way more complex and I ended up doing manually what was already done in the different scripts 😞

Anyway it's now compiling and I could generate the .nupkg properly.

Here it is (renamed as .zip): Jellyfin.SkiaSharp.NativeAssets.LinuxArm.1.68.1.zip

@jairbubbles jairbubbles marked this pull request as ready for review March 28, 2020 09:24
@jairbubbles
Copy link
Contributor Author

@EraYaN can you push the package to NuGet ? (at least in beta so that we can test)

@Bond-009 Bond-009 merged commit 82e9518 into jellyfin:master Mar 28, 2020
@jairbubbles jairbubbles deleted the updateSkia branch March 28, 2020 14:11
@manzajaro
Copy link

Hi,

I have the same issue #2 , How can I update jellyfin?

I have launched "compile-libSkiaSharp.sh" and "cross-compile-libSkiaSharp.sh" and both fail.

"./compile-libSkiaSharp.sh: line 13: /build/buildtools/linux64/gn: No such file or directory"
"./cross-compile-libSkiaSharp.sh: line 62: ./bin/gn: cannot execute binary file: Exec format error"

Distributor ID: Ubuntu
Description: Ubuntu 18.04.4 LTS
Release: 18.04
Codename: bionic
aarch64

Thanks

@jairbubbles
Copy link
Contributor Author

@manzajaro I would recommend to compile using docker by running build-in-docker.sh but obviously you need to install docker on your machine before.

@EraYaN
Copy link
Member

EraYaN commented Mar 30, 2020

I have asked @anthonylavado to upload the nupkg (since I can't myself), should appear somewhere this week.

@manzajaro
Copy link

Will it be available in the next jellyfin update?

@jairbubbles
Copy link
Contributor Author

I have asked @anthonylavado to upload the nupkg (since I can't myself), should appear somewhere this week.

@EraYaN Cool, in the meatime I'll try to generate a local docker ARM image and make sure it does indeed fix the issue.

Will it be available in the next jellyfin update?

I certainly hope so!

@EraYaN
Copy link
Member

EraYaN commented Mar 30, 2020

It's validating now, should be up on NuGet within 24 hours.

@Juansero29
Copy link

I strangely had this problem too on version 1.68.1 with Xamarin.Forms on Visual Studio 2019 yesterday. I was deploying on a physical iPhone SE. Cleaning obj/bin on the .iOS project, then rebuilding, and redeploying did the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest versions are missing
6 participants